Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: tracing/tracing/metrics/system_health/memory_metric.html

Issue 2801153004: Adding malloc allocator metric for objects allocated through shim (Closed)
Patch Set: presubmit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/metrics/system_health/memory_metric_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/system_health/memory_metric.html
diff --git a/tracing/tracing/metrics/system_health/memory_metric.html b/tracing/tracing/metrics/system_health/memory_metric.html
index ebf2cb411940fb7fb681139d5efc4d48cd74e75f..c5cb770de9850a0fb2314f33c1c5d5a4e411fe9f 100644
--- a/tracing/tracing/metrics/system_health/memory_metric.html
+++ b/tracing/tracing/metrics/system_health/memory_metric.html
@@ -68,7 +68,7 @@ tr.exportTo('tr.metrics.sh', function() {
*
* @param {!tr.Model} model The trace model from which the global dumps
* should be extracted.
- * @param {!tr.b.math.Range=} opt_rangeOfInterest If proided, global memory
+ * @param {!tr.b.math.Range=} opt_rangeOfInterest If provided, global memory
* dumps that do not inclusively intersect the range will be skipped.
* @return {!Map<string, !Array<!tr.model.GlobalMemoryDump>} A map from
* browser names to the associated global memory dumps.
@@ -409,6 +409,19 @@ tr.exportTo('tr.metrics.sh', function() {
}
};
+ const SHIM_ALLOCATED_OBJECTS_SIZE = {
+ name: 'shim_allocated_objects_size',
+ unit: sizeInBytes_smallerIsBetter,
+ buildDescriptionPrefix(componentPath, processName) {
+ return buildChromeValueDescriptionPrefix(componentPath, processName, {
+ userFriendlyPropertyName: 'size of all objects allocated through shim',
+ totalUserFriendlyPropertyName:
+ 'size of all allocated objects through shim',
+ componentPreposition: 'by'
+ });
+ }
+ };
+
const LOCKED_SIZE = {
name: 'locked_size',
unit: sizeInBytes_smallerIsBetter,
@@ -445,6 +458,7 @@ tr.exportTo('tr.metrics.sh', function() {
const CHROME_VALUE_PROPERTIES = [
EFFECTIVE_SIZE,
ALLOCATED_OBJECTS_SIZE,
+ SHIM_ALLOCATED_OBJECTS_SIZE,
LOCKED_SIZE,
PEAK_SIZE
];
@@ -835,7 +849,7 @@ tr.exportTo('tr.metrics.sh', function() {
* component: ['system', 'native_heap'],
* property: 'proportional_resident_size',
* value: pssExtractedFromProcessDump2,
- * descriptionPrefixBuilder: function(componentPath) {
+ * descriptionPrefixBuilder(componentPath) {
* return 'PSS of ' + componentPath.join('/') + ' in';
* }
* });
« no previous file with comments | « no previous file | tracing/tracing/metrics/system_health/memory_metric_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698