Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tracing/tracing/metrics/system_health/memory_metric_test.html

Issue 2801153004: Adding malloc allocator metric for objects allocated through shim (Closed)
Patch Set: presubmit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/system_health/memory_metric.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/system_health/memory_metric_test.html
diff --git a/tracing/tracing/metrics/system_health/memory_metric_test.html b/tracing/tracing/metrics/system_health/memory_metric_test.html
index 3906e963ecbc07ca372cbb45c793b18d90f8604c..e99669ed1e9361fd7e6680b700adbe6fbd874096 100644
--- a/tracing/tracing/metrics/system_health/memory_metric_test.html
+++ b/tracing/tracing/metrics/system_health/memory_metric_test.html
@@ -392,7 +392,8 @@ tr.b.unittest.testSuite(function() {
pmdBrowser1.memoryAllocatorDumps = [
newAllocatorDump(pmdBrowser1, 'malloc', {numerics: {
size: 8,
- allocated_objects_size: 4
+ allocated_objects_size: 4,
+ shim_allocated_objects_size: 3,
}})
];
pmdBrowser1.totals = {
@@ -544,7 +545,8 @@ tr.b.unittest.testSuite(function() {
pmdBrowser3.memoryAllocatorDumps = [
newAllocatorDump(pmdBrowser3, 'malloc', {numerics: {
size: 8000,
- allocated_objects_size: 4000
+ allocated_objects_size: 4000,
+ shim_allocated_objects_size: 3000
}})
];
const pmdRendererB3 = addProcessMemoryDump(gmd3, pRendererB, {ts: 61});
@@ -626,6 +628,13 @@ tr.b.unittest.testSuite(function() {
description: 'total size of all allocated objects reported by Chrome ' +
'for all processes in Chrome'
},
+ 'memory:chrome:all_processes:reported_by_chrome:shim_allocated_objects_size':
+ {
+ value: [3, 0, 3000, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'total size of all allocated objects through shim ' +
+ 'reported by Chrome for all processes in Chrome'
+ },
'memory:chrome:all_processes:reported_by_chrome:peak_size':
{
value: [0, 2 + 20 + 200, 0, 0],
@@ -675,6 +684,13 @@ tr.b.unittest.testSuite(function() {
unit: sizeInBytes_smallerIsBetter,
description: 'effective size of malloc in all processes in Chrome'
},
+ 'memory:chrome:all_processes:reported_by_chrome:malloc:shim_allocated_objects_size':
+ {
+ value: [3, 0, 3000, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'size of all objects allocated through shim by malloc in ' +
+ 'all processes in Chrome'
+ },
'memory:chrome:all_processes:reported_by_chrome:malloc:allocated_objects_size':
{
value: [4, 40 + 750, 4000, 0],
@@ -871,6 +887,13 @@ tr.b.unittest.testSuite(function() {
description: 'total size of all allocated objects reported by Chrome ' +
'for the browser process in Chrome'
},
+ 'memory:chrome:browser_process:reported_by_chrome:shim_allocated_objects_size':
+ {
+ value: [3, 0, 3000, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'total size of all allocated objects through shim ' +
+ 'reported by Chrome for the browser process in Chrome'
+ },
'memory:chrome:browser_process:reported_by_chrome:malloc:effective_size': {
value: [8, 120 - 40, 8000, 80000],
unit: sizeInBytes_smallerIsBetter,
@@ -883,6 +906,13 @@ tr.b.unittest.testSuite(function() {
description: 'size of all objects allocated by malloc in the ' +
'browser process in Chrome'
},
+ 'memory:chrome:browser_process:reported_by_chrome:malloc:shim_allocated_objects_size':
+ {
+ value: [3, 0, 3000, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'size of all objects allocated through shim by malloc in ' +
+ 'the browser process in Chrome'
+ },
'memory:chrome:browser_process:reported_by_chrome:tracing:effective_size': {
value: [0, 40, 0, 0],
unit: sizeInBytes_smallerIsBetter,
« no previous file with comments | « tracing/tracing/metrics/system_health/memory_metric.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698