Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2800853002: [instrumentation] Turn inspector override "probes" return values into output parameters. (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, Yoav Weiss, lushnikov+blink_chromium.org, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, kozyatinskiy+blink_chromium.org, blink-worker-reviews_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[instrumentation] Turn inspector override "probes" return values into output parameters. This is a temporary measure. They should eventually become regular functions. BUG=695625 Review-Url: https://codereview.chromium.org/2800853002 Cr-Original-Commit-Position: refs/heads/master@{#462286} Committed: https://chromium.googlesource.com/chromium/src/+/66d34a387594b54f3fb22a30cb0fd57ff972a002 Review-Url: https://codereview.chromium.org/2800853002 Cr-Commit-Position: refs/heads/master@{#462554} Committed: https://chromium.googlesource.com/chromium/src/+/3e927e1d9502976b10a4da9551e7eaae7bb4f174

Patch Set 1 #

Patch Set 2 : fix win build #

Patch Set 3 : update BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -70 lines) Patch
M third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py View 2 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl View 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 4 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 1 chunk +18 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/probe/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/probe/CoreProbes.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/probe/CoreProbes.pidl View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
alph
ptal
3 years, 8 months ago (2017-04-05 18:04:15 UTC) #2
pfeldman
lgtm
3 years, 8 months ago (2017-04-05 18:08:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800853002/1
3 years, 8 months ago (2017-04-05 19:15:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/398996)
3 years, 8 months ago (2017-04-05 19:58:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800853002/20001
3 years, 8 months ago (2017-04-05 20:32:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/66d34a387594b54f3fb22a30cb0fd57ff972a002
3 years, 8 months ago (2017-04-06 00:10:27 UTC) #13
tasak
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2797253005/ by tasak@google.com. ...
3 years, 8 months ago (2017-04-06 02:21:33 UTC) #14
tasak
On 2017/04/06 02:21:33, tasak wrote: > A revert of this CL (patchset #2 id:20001) has ...
3 years, 8 months ago (2017-04-06 02:22:48 UTC) #15
alph
On 2017/04/06 02:22:48, tasak wrote: > On 2017/04/06 02:21:33, tasak wrote: > > A revert ...
3 years, 8 months ago (2017-04-06 16:12:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800853002/40001
3 years, 8 months ago (2017-04-06 16:32:58 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 18:36:54 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e927e1d9502976b10a4da9551e7...

Powered by Google App Engine
This is Rietveld 408576698