Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h

Issue 2800853002: [instrumentation] Turn inspector override "probes" return values into output parameters. (Closed)
Patch Set: update BUILD.gn Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
index d7861d168574ca7987decf37668993fceaa25de9..a8672589d3e9f53ead730c61bbe834293472b05f 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
@@ -73,7 +73,7 @@ class CORE_EXPORT InspectorNetworkAgent final
~InspectorNetworkAgent() override;
DECLARE_VIRTUAL_TRACE();
- // Called from instrumentation.
+ // Probes.
void didBlockRequest(LocalFrame*,
const ResourceRequest&,
DocumentLoader*,
@@ -114,8 +114,8 @@ class CORE_EXPORT InspectorNetworkAgent final
void didCommitLoad(LocalFrame*, DocumentLoader*);
void scriptImported(unsigned long identifier, const String& sourceString);
void didReceiveScriptResponse(unsigned long identifier);
- bool shouldForceCORSPreflight();
- bool shouldBlockRequest(const ResourceRequest&);
+ void shouldForceCORSPreflight(bool* result);
+ void shouldBlockRequest(const ResourceRequest&, bool* result);
void documentThreadableLoaderStartedLoadingForClient(unsigned long identifier,
ThreadableLoaderClient*);

Powered by Google App Engine
This is Rietveld 408576698