third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp - Issue 2800853002: [instrumentation] Turn inspector override "probes" return values into output parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

Issue 2800853002: [instrumentation] Turn inspector override "probes" return values into output parameters. (Closed)

Patch Set: update BUILD.gn Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

index 747c7f381bfd7694dc65c36e6fee2eaec26731df..07ae3e3795a89e8755350dd2aa2908ddea0a5294 100644

--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

@@ -37,6 +37,7 @@

#include "core/frame/FrameConsole.h"

#include "core/frame/LocalFrame.h"

#include "core/frame/LocalFrameClient.h"

+#include "core/inspector/InspectorNetworkAgent.h"

#include "core/inspector/InspectorTraceEvents.h"

#include "core/loader/DocumentThreadableLoaderClient.h"

#include "core/loader/FrameLoader.h"

@@ -386,8 +387,9 @@ void DocumentThreadableLoader::makeCrossOriginAccessRequest(

crossOriginRequest.setServiceWorkerMode(

WebURLRequest::ServiceWorkerMode::None);

- bool shouldForcePreflight = request.isExternalRequest() ||

- probe::shouldForceCORSPreflight(document());

+ bool shouldForcePreflight = request.isExternalRequest();

+ if (!shouldForcePreflight)

+ probe::shouldForceCORSPreflight(document(), &shouldForcePreflight);

bool canSkipPreflight =

CrossOriginPreflightResultCache::shared().canSkipPreflight(

getSecurityOrigin()->toString(), crossOriginRequest.url(),