Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp

Issue 2800853002: [instrumentation] Turn inspector override "probes" return values into output parameters. (Closed)
Patch Set: update BUILD.gn Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/probe/CoreProbes.pidl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
index 346c38d4e6e246a1d2ee5d5f1c1538d936941a10..534db8f9e6de8b7ab7382516f5fa80ccbebfe654 100644
--- a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
@@ -7,6 +7,7 @@
#include "core/frame/FrameConsole.h"
#include "core/inspector/IdentifiersFactory.h"
#include "core/inspector/InspectorTraceEvents.h"
+#include "core/inspector/InspectorWorkerAgent.h"
#include "core/inspector/WorkerInspectorController.h"
#include "core/probe/CoreProbes.h"
#include "core/workers/WorkerGlobalScope.h"
@@ -51,9 +52,10 @@ const String& WorkerInspectorProxy::inspectorId() {
WorkerThreadStartMode WorkerInspectorProxy::workerStartMode(
Document* document) {
- if (probe::shouldWaitForDebuggerOnWorkerStart(document))
- return PauseWorkerGlobalScopeOnStart;
- return DontPauseWorkerGlobalScopeOnStart;
+ bool result = false;
+ probe::shouldWaitForDebuggerOnWorkerStart(document, &result);
+ return result ? PauseWorkerGlobalScopeOnStart
+ : DontPauseWorkerGlobalScopeOnStart;
}
void WorkerInspectorProxy::workerThreadCreated(Document* document,
@@ -65,7 +67,8 @@ void WorkerInspectorProxy::workerThreadCreated(Document* document,
inspectorProxies().insert(this);
// We expect everyone starting worker thread to synchronously ask for
// workerStartMode right before.
- bool waitingForDebugger = probe::shouldWaitForDebuggerOnWorkerStart(document);
+ bool waitingForDebugger = false;
+ probe::shouldWaitForDebuggerOnWorkerStart(document, &waitingForDebugger);
probe::didStartWorker(document, this, waitingForDebugger);
}
« no previous file with comments | « third_party/WebKit/Source/core/probe/CoreProbes.pidl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698