Settings reset prompt: add more UI metrics.

Settings reset prompt: add more UI metrics.

Adding user actions and a histogram so that, when the settings reset
prompt is not accepted, we can distinguish between cases when user
clicks the cancel button versus dismisses the prompt in some other
way.

BUG=

Review-Url: https://codereview.chromium.org/2800773003
Cr-Commit-Position: refs/heads/master@{#463322}
Committed: https://chromium.googlesource.com/chromium/src/+/37182490838f1b74bdea1376b0d0e6c23710d043

[alito, 2017-04-05 20:30:30]

alito@chromium.org changed reviewers:
+ jwd@chromium.org

[alito, 2017-04-05 20:30:31]

Jesse, PTAL.

[jwd, 2017-04-07 17:41:08]

lgtm

[alito, 2017-04-07 17:42:53]

alito@chromium.org changed reviewers:
+ csharp@chromium.org

[alito, 2017-04-07 17:42:54]

Thanks Jesse.

Chris, could you take a look?

[alito, 2017-04-07 17:43:35]

Description was changed from

==========
Settings reset prompt: add more UI metrics.

Adding user actions and a histogram so that, when the settings reset
prompt is not accepted, we can distinguish between cases when user
clicks the cancel button versus dismisses the prompt in some other
way.

BUG=
==========

to

==========
Settings reset prompt: add more UI metrics.

Adding user actions and a histogram so that, when the settings reset
prompt is not accepted, we can distinguish between cases when user
clicks the cancel button versus dismisses the prompt in some other
way.

BUG=
==========

[csharp, 2017-04-07 18:23:28]

lgtm

https://codereview.chromium.org/2800773003/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2800773003/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:14485: <action
name="SettingsResetPrompt_Declined">
As discussed, probably worth deprecating this and creating a new cancelled
action (to help make the difference between declined and dismissed clearer)

[alito, 2017-04-07 19:58:58]

The old dismiss histogram and user action are now deprected and a a new cancel
histogram and user action are used.

https://codereview.chromium.org/2800773003/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2800773003/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:14485: <action
name="SettingsResetPrompt_Declined">
On 2017/04/07 18:23:28, csharp wrote:
> As discussed, probably worth deprecating this and creating a new cancelled
> action (to help make the difference between declined and dismissed clearer)

Done.

[jwd, 2017-04-07 20:02:21]

lgtm

[alito, 2017-04-07 20:03:10]

The CQ bit was checked by alito@chromium.org

[alito, 2017-04-07 20:03:11]

The patchset sent to the CQ was uploaded after l-g-t-m from csharp@chromium.org
Link to the patchset: https://codereview.chromium.org/2800773003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-07 20:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 20:20:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alito, 2017-04-07 20:24:51]

Adding sky@ for OWNERS approval for:
chrome/browser/ui/views/settings_reset_prompt_dialog.*

[alito, 2017-04-07 20:25:34]

alito@chromium.org changed reviewers:
+ sky@chromium.org

[alito, 2017-04-07 20:25:35]

Actually adding sky@ as reviewer

[sky, 2017-04-07 23:20:06]

https://codereview.chromium.org/2800773003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/settings_reset_prompt_dialog.cc (right):

https://codereview.chromium.org/2800773003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/settings_reset_prompt_dialog.cc:57: Close();
The destructor has no need to close as by the time the destructor is called the
widget is long since delete. Instead move the call to the controller here. Also,
could you remove interaction_done_ and instead rely on controller_? I'm
suggesting you null out controller_ in Accept/Cancel.

[alito, 2017-04-07 23:50:43]

Scott, I've made the change you suggested. PTAnL.

https://codereview.chromium.org/2800773003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/settings_reset_prompt_dialog.cc (right):

https://codereview.chromium.org/2800773003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/settings_reset_prompt_dialog.cc:57: Close();
On 2017/04/07 23:20:06, sky wrote:
> The destructor has no need to close as by the time the destructor is called
the
> widget is long since delete. Instead move the call to the controller here.
Also,
> could you remove interaction_done_ and instead rely on controller_? I'm
> suggesting you null out controller_ in Accept/Cancel.

Done.

[sky, 2017-04-10 16:07:02]

LGTM

[alito, 2017-04-10 17:00:37]

The CQ bit was checked by alito@chromium.org

[alito, 2017-04-10 17:00:37]

The patchset sent to the CQ was uploaded after l-g-t-m from csharp@chromium.org,
jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2800773003/#ps60001
(title: "Remove interaction_done_")

[commit-bot: I haz the power, 2017-04-10 17:01:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:02:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491843637435680,
"parent_rev": "f47442541a1b4292f7c428717a90a15712f9c62b", "commit_rev":
"37182490838f1b74bdea1376b0d0e6c23710d043"}

[commit-bot: I haz the power, 2017-04-10 18:03:46]

Description was changed from

==========
Settings reset prompt: add more UI metrics.

Adding user actions and a histogram so that, when the settings reset
prompt is not accepted, we can distinguish between cases when user
clicks the cancel button versus dismisses the prompt in some other
way.

BUG=
==========

to

==========
Settings reset prompt: add more UI metrics.

Adding user actions and a histogram so that, when the settings reset
prompt is not accepted, we can distinguish between cases when user
clicks the cancel button versus dismisses the prompt in some other
way.

BUG=

Review-Url: https://codereview.chromium.org/2800773003
Cr-Commit-Position: refs/heads/master@{#463322}
Committed:
https://chromium.googlesource.com/chromium/src/+/37182490838f1b74bdea1376b0d0...
==========

[commit-bot: I haz the power, 2017-04-10 18:03:48]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/37182490838f1b74bdea1376b0d0...