Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5683)

Unified Diff: chrome/browser/ui/views/settings_reset_prompt_dialog.h

Issue 2800773003: Settings reset prompt: add more UI metrics. (Closed)
Patch Set: Remove interaction_done_ Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/settings_reset_prompt_dialog.h
diff --git a/chrome/browser/ui/views/settings_reset_prompt_dialog.h b/chrome/browser/ui/views/settings_reset_prompt_dialog.h
index 5a2414839092a84cb7780b2358b974f0dd360327..3f87c01b8242ac20f22227c9acaddb3084af9c28 100644
--- a/chrome/browser/ui/views/settings_reset_prompt_dialog.h
+++ b/chrome/browser/ui/views/settings_reset_prompt_dialog.h
@@ -46,6 +46,10 @@ class SettingsResetPromptDialog : public views::DialogDelegateView {
base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
bool Accept() override;
bool Cancel() override;
+ // We override |Close()| because we want to distinguish in our metrics between
+ // users clicking the cancel button versus dismissing the dialog in other
+ // ways.
+ bool Close() override;
// views::View overrides.
gfx::Size GetPreferredSize() const override;
@@ -53,7 +57,6 @@ class SettingsResetPromptDialog : public views::DialogDelegateView {
private:
Browser* browser_;
safe_browsing::SettingsResetPromptController* controller_;
- bool interaction_done_;
DISALLOW_COPY_AND_ASSIGN(SettingsResetPromptDialog);
};

Powered by Google App Engine
This is Rietveld 408576698