Settings reset prompt: add more UI metrics.

chrome/browser/ui/views/settings_reset_prompt_dialog.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/settings_reset_prompt_dialog.h"
 
 #include "chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "components/constrained_window/constrained_window_views.h"
@@ skipping 36 matching lines @@
       new views::StyledLabel(controller_->GetMainText(), /*listener=*/nullptr);
   views::StyledLabel::RangeStyleInfo url_style;
   url_style.weight = gfx::Font::Weight::BOLD;
   dialog_label->AddStyleRange(controller_->GetMainTextUrlRange(), url_style);
   AddChildView(dialog_label);
 }
 
 SettingsResetPromptDialog::~SettingsResetPromptDialog() {
   // Make sure the controller is correctly notified in case the dialog widget is
   // closed by some other means than the dialog buttons.
   Close();

[sky, 2017/04/07 23:20:06]

The destructor has no need to close as by the time the destructor is called the
widget is long since delete. Instead move the call to the controller here. Also,
could you remove interaction_done_ and instead rely on controller_? I'm
suggesting you null out controller_ in Accept/Cancel.

[alito, 2017/04/07 23:50:43]

Done.

 }
 
 void SettingsResetPromptDialog::Show(Browser* browser) {
   DCHECK(browser);
   browser_ = browser;
   BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
   constrained_window::CreateBrowserModalDialogViews(
       this, browser_view->GetNativeWindow())
       ->Show();
   controller_->DialogShown();
@@ skipping 39 matching lines @@
 }
 
 bool SettingsResetPromptDialog::Cancel() {
   if (!interaction_done_) {
     interaction_done_ = true;
     controller_->Cancel();
   }
   return true;
 }
 
+bool SettingsResetPromptDialog::Close() {
+  if (!interaction_done_) {
+    interaction_done_ = true;
+    controller_->Close();
+  }
+  return true;
+}
+
 // View overrides.
 
 gfx::Size SettingsResetPromptDialog::GetPreferredSize() const {
   return gfx::Size(kDialogWidth, GetHeightForWidth(kDialogWidth));
 }