chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc - Issue 2800773003: Settings reset prompt: add more UI metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc

Issue 2800773003: Settings reset prompt: add more UI metrics. (Closed)

Patch Set: Remove interaction_done_ Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h ('k') | chrome/browser/ui/views/settings_reset_prompt_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc

diff --git a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc

index a737bdec30537efb12581281bb2cfa2c5ddd175d..31fe8da12ff76cbc3db204804cbd3a20d2201dd8 100644

--- a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc

+++ b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc

@@ -170,8 +170,17 @@ void SettingsResetPromptController::Accept() {

void SettingsResetPromptController::Cancel() {

DCHECK(!time_dialog_shown_.is_null());

- base::RecordAction(base::UserMetricsAction("SettingsResetPrompt_Declined"));

- UMA_HISTOGRAM_LONG_TIMES_100("SettingsResetPrompt.TimeUntilDeclined",

+ base::RecordAction(base::UserMetricsAction("SettingsResetPrompt_Canceled"));

+ UMA_HISTOGRAM_LONG_TIMES_100("SettingsResetPrompt.TimeUntilCanceled",

+ base::Time::Now() - time_dialog_shown_);

+ UMA_HISTOGRAM_BOOLEAN("SettingsResetPrompt.PromptAccepted", false);

+ OnInteractionDone();

+void SettingsResetPromptController::Close() {

+ DCHECK(!time_dialog_shown_.is_null());

+ base::RecordAction(base::UserMetricsAction("SettingsResetPrompt_Dismissed"));

+ UMA_HISTOGRAM_LONG_TIMES_100("SettingsResetPrompt.TimeUntilDismissed",

base::Time::Now() - time_dialog_shown_);

UMA_HISTOGRAM_BOOLEAN("SettingsResetPrompt.PromptAccepted", false);

OnInteractionDone();