[DevTools] Calculate target type and title once in constructor

[DevTools] Calculate target type and title once in constructor

This is a logical thing to do by itself, improves performance and makes
it easier to reason about things.

It may also help to prevent crashes if we somehow get into inconsistent state
by not calling delegate methods at random times. Although not directly
fixing the linked crash, I expect it to go away.

BUG=704346
TBR=dtrainor@chromium.org

Review-Url: https://codereview.chromium.org/2799783006
Cr-Commit-Position: refs/heads/master@{#462959}
Committed: https://chromium.googlesource.com/chromium/src/+/7a0e557c4434a838ab29021ae039504fbab4f564

[dgozman, 2017-04-06 22:44:49]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 22:45:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:34:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2017-04-07 00:50:15]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 00:51:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 02:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 02:42:49]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-07 02:46:05]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-04-07 02:46:06]

Could you please take a look?

[pfeldman, 2017-04-07 18:31:03]

lgtm

https://codereview.chromium.org/2799783006/diff/20001/content/browser/devtool...
File content/browser/devtools/render_frame_devtools_agent_host.cc (right):

https://codereview.chromium.org/2799783006/diff/20001/content/browser/devtool...
content/browser/devtools/render_frame_devtools_agent_host.cc:469: title_ =
manager->delegate()->GetTargetTitle(host);
meh

[dgozman, 2017-04-07 18:44:39]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:45:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:54:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2017-04-07 18:56:16]

Description was changed from

==========
[DevTools] Calculate target type and title once in constructor

This is a logical thing to do by itself, improves performance and makes
it easier to reason about things.

It may also help to prevent crashes if we somehow get into inconsistent state
by not calling delegate methods at random times. Although not directly
fixing the linked crash, I expect it to go away.

BUG=704346
==========

to

==========
[DevTools] Calculate target type and title once in constructor

This is a logical thing to do by itself, improves performance and makes
it easier to reason about things.

It may also help to prevent crashes if we somehow get into inconsistent state
by not calling delegate methods at random times. Although not directly
fixing the linked crash, I expect it to go away.

BUG=704346
TBR=dtrainor@chromium.org
==========

[dgozman, 2017-04-07 18:56:47]

TBR'ing dtrainor for chrome/browser/android

[dgozman, 2017-04-07 18:56:50]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:57:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:27:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491591410775760,
"parent_rev": "36640ecf2e136c9d8d4dd1a4a25d9175129bb587", "commit_rev":
"7a0e557c4434a838ab29021ae039504fbab4f564"}

[commit-bot: I haz the power, 2017-04-07 19:27:41]

Description was changed from

==========
[DevTools] Calculate target type and title once in constructor

This is a logical thing to do by itself, improves performance and makes
it easier to reason about things.

It may also help to prevent crashes if we somehow get into inconsistent state
by not calling delegate methods at random times. Although not directly
fixing the linked crash, I expect it to go away.

BUG=704346
TBR=dtrainor@chromium.org
==========

to

==========
[DevTools] Calculate target type and title once in constructor

This is a logical thing to do by itself, improves performance and makes
it easier to reason about things.

It may also help to prevent crashes if we somehow get into inconsistent state
by not calling delegate methods at random times. Although not directly
fixing the linked crash, I expect it to go away.

BUG=704346
TBR=dtrainor@chromium.org

Review-Url: https://codereview.chromium.org/2799783006
Cr-Commit-Position: refs/heads/master@{#462959}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a0e557c4434a838ab29021ae039...
==========

[commit-bot: I haz the power, 2017-04-07 19:27:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a0e557c4434a838ab29021ae039...