chrome/browser/android/devtools_manager_delegate_android.h - Issue 2799783006: [DevTools] Calculate target type and title once in constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/devtools_manager_delegate_android.h

Issue 2799783006: [DevTools] Calculate target type and title once in constructor (Closed)

Patch Set: extensions fix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/devtools_manager_delegate_android.h

diff --git a/chrome/browser/android/devtools_manager_delegate_android.h b/chrome/browser/android/devtools_manager_delegate_android.h

index 8b9f8177406440c59a093b23dcca825e4271111b..4aa8d1778090a0b4970b0fc7354ae5176d49961c 100644

--- a/chrome/browser/android/devtools_manager_delegate_android.h

+++ b/chrome/browser/android/devtools_manager_delegate_android.h

@@ -27,7 +27,6 @@ class DevToolsManagerDelegateAndroid :

content::DevToolsAgentHost* agent_host,

base::DictionaryValue* command_dict) override;

std::string GetTargetType(content::RenderFrameHost* host) override;

- std::string GetTargetTitle(content::RenderFrameHost* host) override;

bool DiscoverTargets(

const content::DevToolsAgentHost::DiscoveryCallback& callback) override;

scoped_refptr<content::DevToolsAgentHost> CreateNewTarget(