Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: chrome/browser/android/devtools_manager_delegate_android.h

Issue 2799783006: [DevTools] Calculate target type and title once in constructor (Closed)
Patch Set: extensions fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "content/public/browser/devtools_agent_host_observer.h" 12 #include "content/public/browser/devtools_agent_host_observer.h"
13 #include "content/public/browser/devtools_manager_delegate.h" 13 #include "content/public/browser/devtools_manager_delegate.h"
14 14
15 class DevToolsNetworkProtocolHandler; 15 class DevToolsNetworkProtocolHandler;
16 16
17 class DevToolsManagerDelegateAndroid : 17 class DevToolsManagerDelegateAndroid :
18 public content::DevToolsManagerDelegate, 18 public content::DevToolsManagerDelegate,
19 public content::DevToolsAgentHostObserver { 19 public content::DevToolsAgentHostObserver {
20 public: 20 public:
21 DevToolsManagerDelegateAndroid(); 21 DevToolsManagerDelegateAndroid();
22 ~DevToolsManagerDelegateAndroid() override; 22 ~DevToolsManagerDelegateAndroid() override;
23 23
24 private: 24 private:
25 // content::DevToolsManagerDelegate implementation. 25 // content::DevToolsManagerDelegate implementation.
26 base::DictionaryValue* HandleCommand( 26 base::DictionaryValue* HandleCommand(
27 content::DevToolsAgentHost* agent_host, 27 content::DevToolsAgentHost* agent_host,
28 base::DictionaryValue* command_dict) override; 28 base::DictionaryValue* command_dict) override;
29 std::string GetTargetType(content::RenderFrameHost* host) override; 29 std::string GetTargetType(content::RenderFrameHost* host) override;
30 std::string GetTargetTitle(content::RenderFrameHost* host) override;
31 bool DiscoverTargets( 30 bool DiscoverTargets(
32 const content::DevToolsAgentHost::DiscoveryCallback& callback) override; 31 const content::DevToolsAgentHost::DiscoveryCallback& callback) override;
33 scoped_refptr<content::DevToolsAgentHost> CreateNewTarget( 32 scoped_refptr<content::DevToolsAgentHost> CreateNewTarget(
34 const GURL& url) override; 33 const GURL& url) override;
35 std::string GetDiscoveryPageHTML() override; 34 std::string GetDiscoveryPageHTML() override;
36 35
37 // content::DevToolsAgentHostObserver overrides. 36 // content::DevToolsAgentHostObserver overrides.
38 void DevToolsAgentHostAttached( 37 void DevToolsAgentHostAttached(
39 content::DevToolsAgentHost* agent_host) override; 38 content::DevToolsAgentHost* agent_host) override;
40 void DevToolsAgentHostDetached( 39 void DevToolsAgentHostDetached(
41 content::DevToolsAgentHost* agent_host) override; 40 content::DevToolsAgentHost* agent_host) override;
42 41
43 std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_; 42 std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_;
44 43
45 DISALLOW_COPY_AND_ASSIGN(DevToolsManagerDelegateAndroid); 44 DISALLOW_COPY_AND_ASSIGN(DevToolsManagerDelegateAndroid);
46 }; 45 };
47 46
48 #endif // CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_ 47 #endif // CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698