Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/browser/android/devtools_manager_delegate_android.cc

Issue 2799783006: [DevTools] Calculate target type and title once in constructor (Closed)
Patch Set: extensions fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/devtools_manager_delegate_android.cc
diff --git a/chrome/browser/android/devtools_manager_delegate_android.cc b/chrome/browser/android/devtools_manager_delegate_android.cc
index 96f58833188456d5dc1055b492e917f0e0fd1ec8..0d84421c0d559ac1d731bfc648f0b7df08f040ba 100644
--- a/chrome/browser/android/devtools_manager_delegate_android.cc
+++ b/chrome/browser/android/devtools_manager_delegate_android.cc
@@ -186,14 +186,6 @@ std::string DevToolsManagerDelegateAndroid::GetTargetType(
DevToolsAgentHost::kTypeOther;
}
-std::string DevToolsManagerDelegateAndroid::GetTargetTitle(
- content::RenderFrameHost* host) {
- content::WebContents* web_contents =
- content::WebContents::FromRenderFrameHost(host);
- TabAndroid* tab = TabAndroid::FromWebContents(web_contents);
- return tab ? base::UTF16ToUTF8(tab->GetTitle()) : "";
-}
-
bool DevToolsManagerDelegateAndroid::DiscoverTargets(
const DevToolsAgentHost::DiscoveryCallback& callback) {
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698