Issue 279903002: reland hide get/setLocalMatrix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279903002: reland hide get/setLocalMatrix (Closed)

Created:
6 years, 7 months ago by reed1

Modified:
6 years, 7 months ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

re-land hide get/setLocalMatrix This reverts commit b1d702a43b07934f5b001b1b09db2c57ede909a1. TBR=scroggo@google.com Committed: http://code.google.com/p/skia/source/detail?r=14702

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : adjust new gm to not call setLocalMatrix #

Patch Set 4 : remember global initialization of flattenables #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -87 lines)			Patch
M	gm/perlinnoise.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkShader.h	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	samplecode/SampleFatBits.cpp	View		3 chunks	+4 lines, -6 lines	0 comments	Download
A	src/core/SkLocalMatrixShader.h	View	1 2 3	1 chunk	+66 lines, -0 lines	0 comments	Download
M	src/core/SkLocalMatrixShader.cpp	View	1 2 3	1 chunk	+2 lines, -56 lines	0 comments	Download
M	src/core/SkPictureShader.cpp	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/core/SkShader.cpp	View	1	3 chunks	+6 lines, -9 lines	1 comment	Download
M	src/effects/SkRectShaderImageFilter.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFDeviceFlattener.cpp	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_chromium.cpp	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	1 2 3	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/279903002/60001

6 years, 7 months ago (2014-05-12 20:35:14 UTC) #2

scroggo

6 years, 7 months ago (2014-05-14 15:03:20 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/279903002/diff/60001/src/core/SkShader.cpp
File src/core/SkShader.cpp (right):

https://codereview.chromium.org/279903002/diff/60001/src/core/SkShader.cpp#ne...
src/core/SkShader.cpp:74: const SkMatrix* m = &total;
Is 'm' still necessary?

Expand Messages | Collapse Messages