Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(56)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/libxml/chromium/libxml2-2.9.4-security-CVE-2017-7376-nanohttp-out-of-bounds-write.patch
Issue
2797923004
:
Improve XML serialization, URI parsing, and XPath node set processing. (Closed)
Patch Set: Rebase.
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/libxml/README.chromium
third_party/libxml/chromium/libxml2-2.9.4-security-CVE-2017-7375-xmlParsePEReference-xxe.patch
third_party/libxml/chromium/libxml2-2.9.4-security-CVE-2017-7376-nanohttp-out-of-bounds-write.patch
third_party/libxml/chromium/libxml2-2.9.4-security-xpath-nodetab-uaf.patch
third_party/libxml/chromium/libxml2-2.9.4-xmlDumpElementContent-null-deref.patch
third_party/libxml/chromium/roll.py
third_party/libxml/src/parser.c
third_party/libxml/src/uri.c
third_party/libxml/src/valid.c
third_party/libxml/src/xpath.c
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/libxml/chromium/libxml2-2.9.4-security-CVE-2017-7375-xmlParsePEReference-xxe.patch
('k') |
third_party/libxml/chromium/libxml2-2.9.4-security-xpath-nodetab-uaf.patch »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
https://bugzilla.gnome.org/show_bug.cgi?id=780690
2
3
--- src/uri.c
4
+++ src/uri.c
5
@@ -12,6 +12,7 @@
6
#include "third_party/libxml/src/libxml.h"
7
8
#include <string.h>
9
+#include <limits.h>
10
11
#include "third_party/libxml/src/include/libxml/xmlmemory.h"
12
#include "third_party/libxml/src/include/libxml/uri.h"
13
@@ -334,7 +335,7 @@ xmlParse3986Port(xmlURIPtr uri, const char **str)
14
cur++;
15
}
16
if (uri != NULL)
17
- uri->port = port & INT_MAX; /* port value modulo INT_MAX+1 */
18
+ uri->port = port & USHRT_MAX; /* port value modulo USHRT_MAX+1 */
19
*str = cur;
20
return(0);
21
}
OLD
NEW
« no previous file with comments
|
« third_party/libxml/chromium/libxml2-2.9.4-security-CVE-2017-7375-xmlParsePEReference-xxe.patch
('k') |
third_party/libxml/chromium/libxml2-2.9.4-security-xpath-nodetab-uaf.patch »
('j') |
no next file with comments »
Issue 2797923004: Improve XML serialization, URI parsing, and XPath node set processing. (Closed)
Created 3 years, 8 months ago by dominicc (has gone to gerrit)
Modified 3 years, 8 months ago
Reviewers: Oliver Chang
Base URL:
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 2797923004:
Improve XML serialization, URI parsing, and XPath node set processing. (Closed)
