third_party/libxml/chromium/libxml2-2.9.4-security-xpath-nodetab-uaf.patch - Issue 2797923004: Improve XML serialization, URI parsing, and XPath node set processing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libxml/chromium/libxml2-2.9.4-security-xpath-nodetab-uaf.patch

Issue 2797923004: Improve XML serialization, URI parsing, and XPath node set processing. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 not upstream yet, fix from nmehta@

	2 see https://docs.google.com/document/d/1-Cd_Yq8MZ7am2ZhKhbDhqZ_L0aLJPBg0w1QLXGVo NmY/edit

	3 and https://bugs.chromium.org/p/chromium/issues/detail?id=705445

	4

	5 --- src/xpath.c 2016-12-25 17:26:52.000000000 -0800

	6 +++ src/xpath.c 2017-03-30 11:15:41.000000000 -0700

	7 @@ -4368,7 +4368,7 @@

	8 }

	9 memset(ret, 0 , (size_t) sizeof(xmlXPathObject));

	10 ret->type = XPATH_XSLT_TREE;

	11 - ret->boolval = 1;

	12 + ret->boolval = 0;

	13 ret->user = (void *) val;

	14 ret->nodesetval = xmlXPathNodeSetCreate(val);

	15 #ifdef XP_DEBUG_OBJ_USAGE

OLD	NEW