Remove base::underlying_type, replace uses with std::underlying_type

Remove base::underlying_type, replace uses with std::underlying_type

Also removes a one-off repeat of base::underlying_type in
safe_numerics_impl. This type trait is now available in the libstdc++
we are building with.

R=dcheng@chromium.org
TBR=treib@chromium.org,gab@chromium.org,rockot@chromium.org,rch@chromium.org
BUG=554293
Review-Url: https://codereview.chromium.org/2797793002
Cr-Commit-Position: refs/heads/master@{#462101}
Committed: https://chromium.googlesource.com/chromium/src/+/6d0446e51df56fa7b2b3a0606fa549217ccf75b6

[danakj, 2017-04-04 19:00:38]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 19:01:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-04-04 19:15:07]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 19:15:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-04-04 19:23:34]

Patchset #2 (id:20001) has been deleted

[danakj, 2017-04-04 19:24:26]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 19:24:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 21:36:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 21:36:01]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-04-04 23:31:58]

Same deal with patchset 1 and 2

[danakj, 2017-04-04 23:32:02]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2017-04-04 23:32:07]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-04 23:33:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-04-04 23:39:54]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-04-04 23:39:55]

lgtm

[commit-bot: I haz the power, 2017-04-05 01:41:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 01:41:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dcheng, 2017-04-05 02:42:17]

lgtm

[danakj, 2017-04-05 15:03:33]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-04-05 15:03:38]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-04-05 15:05:44]

Description was changed from

==========
Remove base::underlying_type, replace uses with std::underlying_type

Also removes a one-off repeat of base::underlying_type in
safe_numerics_impl. This type trait is now available in the libstdc++
we are building with.

R=dcheng@chromium.org
BUG=554293
==========

to

==========
Remove base::underlying_type, replace uses with std::underlying_type

Also removes a one-off repeat of base::underlying_type in
safe_numerics_impl. This type trait is now available in the libstdc++
we are building with.

R=dcheng@chromium.org
TBR=treib@chromium.org,gab@chromium.org,rockot@chromium.org,rch@chromium.org
BUG=554293
==========

[danakj, 2017-04-05 15:05:44]

danakj@chromium.org changed reviewers:
+ gab@chromium.org, rch@chromium.org, rockot@chromium.org, treib@chromium.org

[danakj, 2017-04-05 15:05:55]

+treib@chromium.org for components/ntp_snippets
+gab@chromium.org for components/prefs
+rockot@chromium.org for mojo/
+rch@chromium.org for net/

Will TBR for all of this.

[danakj, 2017-04-05 15:06:01]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-04-05 15:06:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-04-05 15:22:48]

bnc@chromium.org changed reviewers:
+ bnc@chromium.org

[Bence, 2017-04-05 15:22:48]

net/ LGTM.

[commit-bot: I haz the power, 2017-04-05 16:22:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491404761345760,
"parent_rev": "f72b235e0d5e1478276b00bcfa8ab8af1d5637e5", "commit_rev":
"6d0446e51df56fa7b2b3a0606fa549217ccf75b6"}

[commit-bot: I haz the power, 2017-04-05 16:23:28]

Description was changed from

==========
Remove base::underlying_type, replace uses with std::underlying_type

Also removes a one-off repeat of base::underlying_type in
safe_numerics_impl. This type trait is now available in the libstdc++
we are building with.

R=dcheng@chromium.org
TBR=treib@chromium.org,gab@chromium.org,rockot@chromium.org,rch@chromium.org
BUG=554293
==========

to

==========
Remove base::underlying_type, replace uses with std::underlying_type

Also removes a one-off repeat of base::underlying_type in
safe_numerics_impl. This type trait is now available in the libstdc++
we are building with.

R=dcheng@chromium.org
TBR=treib@chromium.org,gab@chromium.org,rockot@chromium.org,rch@chromium.org
BUG=554293

Review-Url: https://codereview.chromium.org/2797793002
Cr-Commit-Position: refs/heads/master@{#462101}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d0446e51df56fa7b2b3a0606fa5...
==========

[commit-bot: I haz the power, 2017-04-05 16:23:30]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6d0446e51df56fa7b2b3a0606fa5...

[gab, 2017-04-06 15:57:40]

On 2017/04/05 15:05:55, danakj wrote:
> https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=+treib@chromium.org for
components/ntp_snippets
> https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=+gab@chromium.org for
components/prefs

lgtm

> https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=+rockot@chromium.org for
mojo/
> https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=+rch@chromium.org for net/
> 
> Will TBR for all of this.