Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2792183003: Remove base::is_trivially_destructible and use the standard library. (Closed)

Created:
3 years, 8 months ago by danakj
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org, Nico
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::is_trivially_destructible and use the standard library. This is available in our linux sysroot now, so we can drop the implementation in base. R=dcheng@chromium.org TBR=jbauman@chromium.org BUG=554293 Review-Url: https://codereview.chromium.org/2792183003 Cr-Commit-Position: refs/heads/master@{#462141} Committed: https://chromium.googlesource.com/chromium/src/+/90acaf829ceba5299b4823723f44ac72bfabf3d8

Patch Set 1 #

Patch Set 2 : triviallydestruct: rebase #

Patch Set 3 : triviallydestruct: rm-tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -50 lines) Patch
M base/optional.h View 2 chunks +1 line, -2 lines 0 comments Download
M base/optional_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/template_util.h View 4 chunks +3 lines, -26 lines 0 comments Download
M base/template_util_unittest.cc View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_register.h View 2 chunks +4 lines, -3 lines 0 comments Download
M base/trace_event/memory_usage_estimator.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/tracing/core/proto_zero_message.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (17 generated)
danakj
And more same deal with patch set 1 and 2
3 years, 8 months ago (2017-04-04 23:32:52 UTC) #7
Nico
lgtm
3 years, 8 months ago (2017-04-04 23:38:28 UTC) #11
dcheng
LGTM
3 years, 8 months ago (2017-04-05 02:53:13 UTC) #14
danakj
+jbauman for components/tracing (will TBR)
3 years, 8 months ago (2017-04-05 15:06:29 UTC) #16
Primiano Tucci (use gerrit)
components/tracing lgtm
3 years, 8 months ago (2017-04-05 15:16:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792183003/40001
3 years, 8 months ago (2017-04-05 16:25:58 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 18:00:27 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/90acaf829ceba5299b4823723f44...

Powered by Google App Engine
This is Rietveld 408576698