Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2790403003: Remove base::is_*assignable as these are now in the linux sysroot. (Closed)

Created:
3 years, 8 months ago by danakj
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org, dcheng, Nico
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::is_*assignable as these are now in the linux sysroot. These were needed when the sysroot's c++ library omitted these, but now it is included with libstdc++4.8. R=thakis@chromium.org BUG=554293 Review-Url: https://codereview.chromium.org/2790403003 Cr-Commit-Position: refs/heads/master@{#461830} Committed: https://chromium.googlesource.com/chromium/src/+/560f5dd2e3a84abf0804bfdf6463311a7d0b88bb

Patch Set 1 #

Patch Set 2 : isassign: removed-tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -116 lines) Patch
M base/bind_unittest.cc View 1 chunk +16 lines, -22 lines 0 comments Download
M base/template_util.h View 2 chunks +0 lines, -61 lines 0 comments Download
M base/template_util_unittest.cc View 1 1 chunk +0 lines, -33 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
danakj
3 years, 8 months ago (2017-04-04 18:49:50 UTC) #7
danakj
Patchset 1 kept all the tests but made them std::. That passed the CQ bots. ...
3 years, 8 months ago (2017-04-04 18:50:22 UTC) #9
dcheng
LGTM (Though I'm not sure if you meant to send this to thakis due to ...
3 years, 8 months ago (2017-04-04 18:52:58 UTC) #11
danakj
On Tue, Apr 4, 2017 at 2:52 PM, <dcheng@chromium.org> wrote: > LGTM > > (Though ...
3 years, 8 months ago (2017-04-04 18:55:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790403003/20001
3 years, 8 months ago (2017-04-04 18:56:33 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 20:56:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/560f5dd2e3a84abf0804bfdf6463...

Powered by Google App Engine
This is Rietveld 408576698