base/logging.h - Issue 2797793002: Remove base::underlying_type, replace uses with std::underlying_type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 2797793002: Remove base::underlying_type, replace uses with std::underlying_type (Closed)

Patch Set: underlyingtype: rm-tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index 7ca018e2279dafcafed6be82d1f08425a1b92eba..1dcb0f71f12ed6b9854524161e7555ea3ac609e1 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -642,7 +642,7 @@ inline typename std::enable_if<

std::is_enum<T>::value,

void>::type

MakeCheckOpValueString(std::ostream* os, const T& v) {

- (*os) << static_cast<typename base::underlying_type<T>::type>(v);

+ (*os) << static_cast<typename std::underlying_type<T>::type>(v);

}

// We need an explicit overload for std::nullptr_t.

« no previous file with comments | « no previous file | base/numerics/safe_conversions_impl.h » ('j') | no next file with comments »