Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2797393002: Scope scissor bug/MSAA/WebGL2 disabling to Adreno series. (Closed)

Created:
3 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 8 months ago
CC:
chromium-reviews, Ken Russell (switch to Gerrit), piman+watch_chromium.org, trchen, Zhenyao Mo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Scope scissor bug/MSAA/WebGL2 disabling to Adreno series. - The scissor bug originally observed on Nexus 7 turns out to affect a swath of Adreno 3xx tablets. Expand it and the associated MSAA disabling to all Adreno 3xx (MSAA is already not trusted on 3xx anyway). - Retarget the Android < 6.0 MSAA+WebGL disabling to Adreno 4xx to clarify this entry is for is a specific remaining problem suspected to exist on certain older 4xx drivers (not very well understood/confirmed, but kainino@ requested this entry remain pending further investigation). - The depth texture blacklist is ancient enough that Adreno 4xx did not exist in those days, so target it to 2xx and 3xx series (even 3xx series may be too new for this bug to affect it, but keeping it there for safety). BUG=707839, 682075 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2797393002 Cr-Commit-Position: refs/heads/master@{#462321} Committed: https://chromium.googlesource.com/chromium/src/+/430d8884a1783783c709bd01e544f682f5134915

Patch Set 1 #

Total comments: 1

Patch Set 2 : Bring back bug list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -73 lines) Patch
M gpu/config/gpu_driver_bug_list.json View 1 5 chunks +8 lines, -16 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_arrays_and_structs_autogen.h View 1 3 chunks +5 lines, -16 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_autogen.cc View 1 6 chunks +11 lines, -9 lines 0 comments Download
M gpu/config/software_rendering_list.json View 4 chunks +8 lines, -9 lines 0 comments Download
M gpu/config/software_rendering_list_arrays_and_structs_autogen.h View 2 chunks +6 lines, -17 lines 0 comments Download
M gpu/config/software_rendering_list_autogen.cc View 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 27 (19 generated)
aelias_OOO_until_Jul13
Hi kainino@, PTAL.
3 years, 8 months ago (2017-04-05 23:35:07 UTC) #4
Zhenyao Mo
lgtm
3 years, 8 months ago (2017-04-06 00:09:38 UTC) #8
Kai Ninomiya
One comment, non-owner LGTM https://codereview.chromium.org/2797393002/diff/1/gpu/config/gpu_driver_bug_list.json File gpu/config/gpu_driver_bug_list.json (right): https://codereview.chromium.org/2797393002/diff/1/gpu/config/gpu_driver_bug_list.json#newcode401 gpu/config/gpu_driver_bug_list.json:401: "cr_bugs": [471200], I think it ...
3 years, 8 months ago (2017-04-06 00:10:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797393002/1
3 years, 8 months ago (2017-04-06 00:10:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797393002/20001
3 years, 8 months ago (2017-04-06 00:21:51 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/423264)
3 years, 8 months ago (2017-04-06 00:34:25 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797393002/20001
3 years, 8 months ago (2017-04-06 00:37:04 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 01:58:28 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/430d8884a1783783c709bd01e544...

Powered by Google App Engine
This is Rietveld 408576698