Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2797253005: Revert of [instrumentation] Turn inspector override "probes" return values into output parameters. (Closed)

Created:
3 years, 8 months ago by tasak
Modified:
3 years, 8 months ago
Reviewers:
dgozman, alph, pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, Yoav Weiss, lushnikov+blink_chromium.org, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, kozyatinskiy+blink_chromium.org, blink-worker-reviews_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [instrumentation] Turn inspector override "probes" return values into output parameters. (patchset #2 id:20001 of https://codereview.chromium.org/2800853002/ ) Reason for revert: I think, this patch causes the following errors: compile confirm no-op failing on 4 builders Linux x64 [10 since first detection] Mac [2 since first detection] Win [3 since first detection] Win x64 [3 since first detection] FYI ninja explain: output gen/blink/core/InspectorOverridesInl.h doesn't exist ninja explain: gen/blink/core/CoreProbesInl.h is dirty https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F36956%2F%2B%2Frecipes%2Fsteps%2Fcompile_confirm_no-op%2F0%2Fstdout Original issue's description: > [instrumentation] Turn inspector override "probes" return values into output parameters. > > This is a temporary measure. They should eventually become regular functions. > > BUG=695625 > > Review-Url: https://codereview.chromium.org/2800853002 > Cr-Commit-Position: refs/heads/master@{#462286} > Committed: https://chromium.googlesource.com/chromium/src/+/66d34a387594b54f3fb22a30cb0fd57ff972a002 TBR=pfeldman@chromium.org,dgozman@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=695625 Review-Url: https://codereview.chromium.org/2797253005 Cr-Commit-Position: refs/heads/master@{#462329} Committed: https://chromium.googlesource.com/chromium/src/+/08edaf185f52af495778ce04d7f28c781031dc66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -82 lines) Patch
M third_party/WebKit/Source/build/scripts/make_instrumenting_probes.py View 2 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesImpl.cpp.tmpl View 2 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/InstrumentingProbesInl.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 4 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +12 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 2 chunks +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/probe/CoreProbes.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/probe/CoreProbes.pidl View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tasak
Created Revert of [instrumentation] Turn inspector override "probes" return values into output parameters.
3 years, 8 months ago (2017-04-06 02:21:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797253005/1
3 years, 8 months ago (2017-04-06 02:22:00 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 02:23:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08edaf185f52af495778ce04d7f2...

Powered by Google App Engine
This is Rietveld 408576698