Chromium Code Reviews
DescriptionRevert of [instrumentation] Turn inspector override "probes" return values into output parameters. (patchset #2 id:20001 of https://codereview.chromium.org/2800853002/ )
Reason for revert:
I think, this patch causes the following errors:
compile confirm no-op failing on 4 builders
Linux x64 [10 since first detection] Mac [2 since first detection] Win [3 since first detection] Win x64 [3 since first detection]
FYI
ninja explain: output gen/blink/core/InspectorOverridesInl.h doesn't exist
ninja explain: gen/blink/core/CoreProbesInl.h is dirty
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F36956%2F%2B%2Frecipes%2Fsteps%2Fcompile_confirm_no-op%2F0%2Fstdout
Original issue's description:
> [instrumentation] Turn inspector override "probes" return values into output parameters.
>
> This is a temporary measure. They should eventually become regular functions.
>
> BUG=695625
>
> Review-Url: https://codereview.chromium.org/2800853002
> Cr-Commit-Position: refs/heads/master@{#462286}
> Committed: https://chromium.googlesource.com/chromium/src/+/66d34a387594b54f3fb22a30cb0fd57ff972a002
TBR=pfeldman@chromium.org,dgozman@chromium.org,alph@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=695625
Review-Url: https://codereview.chromium.org/2797253005
Cr-Commit-Position: refs/heads/master@{#462329}
Committed: https://chromium.googlesource.com/chromium/src/+/08edaf185f52af495778ce04d7f28c781031dc66
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|