Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

Issue 2797253005: Revert of [instrumentation] Turn inspector override "probes" return values into output parameters. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
index 605c0079c59e6baa6c9ca0eb609dd183be64d1f6..eb2b5e8985d68c2a4f73dc3ca06365385f8e6da4 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
@@ -835,41 +835,33 @@
setActiveStyleSheets(document, HeapVector<Member<CSSStyleSheet>>());
}
-void InspectorCSSAgent::forcePseudoState(Element* element,
- CSSSelector::PseudoType pseudoType,
- bool* result) {
+bool InspectorCSSAgent::forcePseudoState(Element* element,
+ CSSSelector::PseudoType pseudoType) {
if (m_nodeIdToForcedPseudoState.isEmpty())
- return;
+ return false;
int nodeId = m_domAgent->boundNodeId(element);
if (!nodeId)
- return;
+ return false;
NodeIdToForcedPseudoState::iterator it =
m_nodeIdToForcedPseudoState.find(nodeId);
if (it == m_nodeIdToForcedPseudoState.end())
- return;
-
- bool force = false;
+ return false;
+
unsigned forcedPseudoState = it->value;
switch (pseudoType) {
case CSSSelector::PseudoActive:
- force = forcedPseudoState & PseudoActive;
- break;
+ return forcedPseudoState & PseudoActive;
case CSSSelector::PseudoFocus:
- force = forcedPseudoState & PseudoFocus;
- break;
+ return forcedPseudoState & PseudoFocus;
case CSSSelector::PseudoHover:
- force = forcedPseudoState & PseudoHover;
- break;
+ return forcedPseudoState & PseudoHover;
case CSSSelector::PseudoVisited:
- force = forcedPseudoState & PseudoVisited;
- break;
+ return forcedPseudoState & PseudoVisited;
default:
- break;
- }
- if (force)
- *result = true;
+ return false;
+ }
}
Response InspectorCSSAgent::getMediaQueries(

Powered by Google App Engine
This is Rietveld 408576698