Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: third_party/WebKit/Source/core/probe/CoreProbes.pidl

Issue 2797253005: Revert of [instrumentation] Turn inspector override "probes" return values into output parameters. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/probe/CoreProbes.pidl
diff --git a/third_party/WebKit/Source/core/probe/CoreProbes.pidl b/third_party/WebKit/Source/core/probe/CoreProbes.pidl
index 0f91d11e2ee29793fa9ced64ae8271ab3f28b5d1..810ff7acc4ee01f3c44fe8c2d8eb8dfbec69f85e 100644
--- a/third_party/WebKit/Source/core/probe/CoreProbes.pidl
+++ b/third_party/WebKit/Source/core/probe/CoreProbes.pidl
@@ -42,7 +42,7 @@
* paramAttr - optional attribute controlling the parameters handling (one attribute per parameter max).
* Keep - pass first parameter (used to access the CoreProbeSink instance) to agents.
*
- * returnValue: "void" for instant probes.
+ * returnValue: C++ return value. Only "void" and "bool" are supported.
* Omitted for the scoped probes.
*
* methodName: C++ name for the public instrumentation method and agents methods.
@@ -156,8 +156,11 @@
CallFunction([Keep] ExecutionContext* context, v8::Local<v8::Function> function, int depth = 0);
UserCallback([Keep] ExecutionContext* context, const char* name, const AtomicString& atomicName, bool recurring, EventTarget* eventTarget = nullptr);
ParseHTML(Document* document, HTMLDocumentParser* parser);
- void forcePseudoState([Keep] Element* element, CSSSelector::PseudoType pseudoState, bool* result);
- void shouldWaitForDebuggerOnWorkerStart(ExecutionContext* context, bool* result);
- void shouldForceCORSPreflight(Document*, bool* result);
- void shouldBlockRequest(LocalFrame*, const ResourceRequest&, bool* result);
}
+
+interface InspectorOverrides {
+ bool forcePseudoState([Keep] Element* element, CSSSelector::PseudoType pseudoState);
+ bool shouldWaitForDebuggerOnWorkerStart(ExecutionContext* context);
+ bool shouldForceCORSPreflight(Document*);
+ bool shouldBlockRequest(LocalFrame*, const ResourceRequest&);
+}
« no previous file with comments | « third_party/WebKit/Source/core/probe/CoreProbes.h ('k') | third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698