Populate the response blob for finished Background Fetches

Populate the response blob for finished Background Fetches

Following this CL we actually populate the response blob for a finished
Background Fetch, which means that the developer can read the response.
In addition, the response time and the response URL chain are also set.

BUG=692579
Review-Url: https://codereview.chromium.org/2796953003
Cr-Commit-Position: refs/heads/master@{#462410}
Committed: https://chromium.googlesource.com/chromium/src/+/47cd96b66744dc81abf3d1dc5561ad2876d5c972

[Peter Beverloo, 2017-04-04 17:29:43]

Patchset #1 (id:1) has been deleted

[Peter Beverloo, 2017-04-04 17:30:22]

peter@chromium.org changed reviewers:
+ avi@chromium.org, harkness@chromium.org

[Peter Beverloo, 2017-04-04 17:30:22]

+harkness
+avi for fake_download_item.*

[Avi (use Gerrit), 2017-04-04 20:01:44]

fake download item lgtm

[harkness, 2017-04-05 09:26:00]

https://codereview.chromium.org/2796953003/diff/20001/content/browser/backgro...
File content/browser/background_fetch/background_fetch_context.cc (right):

https://codereview.chromium.org/2796953003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_context.cc:211: const
std::vector<std::unique_ptr<BlobHandle>>& blob_handles) {
Why do you think we're going to need the blob handles in the delete? At this
point I don't see the ownership on the handles being held anywhere in the
background fetch system.

https://codereview.chromium.org/2796953003/diff/20001/content/browser/backgro...
File content/browser/background_fetch/background_fetch_service_unittest.cc
(right):

https://codereview.chromium.org/2796953003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_service_unittest.cc:118:
base::ScopedTempDir temp_directory_;
Is there a reason we can't rely on the download manager's storage?

[Peter Beverloo, 2017-04-05 09:39:27]

https://codereview.chromium.org/2796953003/diff/20001/content/browser/backgro...
File content/browser/background_fetch/background_fetch_context.cc (right):

https://codereview.chromium.org/2796953003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_context.cc:211: const
std::vector<std::unique_ptr<BlobHandle>>& blob_handles) {
On 2017/04/05 09:26:00, harkness wrote:
> Why do you think we're going to need the blob handles in the delete? At this
> point I don't see the ownership on the handles being held anywhere in the
> background fetch system.

We don't, but we need to keep the handles alive for the duration of the event.
(This is the callback passed to
EventDispatcher::DispatchBackgroundFetchedEvent.)

https://codereview.chromium.org/2796953003/diff/20001/content/browser/backgro...
File content/browser/background_fetch/background_fetch_service_unittest.cc
(right):

https://codereview.chromium.org/2796953003/diff/20001/content/browser/backgro...
content/browser/background_fetch/background_fetch_service_unittest.cc:118:
base::ScopedTempDir temp_directory_;
On 2017/04/05 09:26:00, harkness wrote:
> Is there a reason we can't rely on the download manager's storage?

This is a test.

[harkness, 2017-04-06 08:27:11]

lgtm

[Peter Beverloo, 2017-04-06 09:19:59]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-04-06 09:20:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 10:10:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491470399526770,
"parent_rev": "bb3c4183e9c896ca0be7585285617dd975109e07", "commit_rev":
"47cd96b66744dc81abf3d1dc5561ad2876d5c972"}

[commit-bot: I haz the power, 2017-04-06 10:11:31]

Description was changed from

==========
Populate the response blob for finished Background Fetches

Following this CL we actually populate the response blob for a finished
Background Fetch, which means that the developer can read the response.
In addition, the response time and the response URL chain are also set.

BUG=692579
==========

to

==========
Populate the response blob for finished Background Fetches

Following this CL we actually populate the response blob for a finished
Background Fetch, which means that the developer can read the response.
In addition, the response time and the response URL chain are also set.

BUG=692579

Review-Url: https://codereview.chromium.org/2796953003
Cr-Commit-Position: refs/heads/master@{#462410}
Committed:
https://chromium.googlesource.com/chromium/src/+/47cd96b66744dc81abf3d1dc5561...
==========

[commit-bot: I haz the power, 2017-04-06 10:11:32]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/47cd96b66744dc81abf3d1dc5561...