Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2796973002: Unify the two overridden DownloadManagers used by Background Fetch (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
harkness
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, jam, harkness+watch_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify the two overridden DownloadManagers used by Background Fetch BUG= Review-Url: https://codereview.chromium.org/2796973002 Cr-Commit-Position: refs/heads/master@{#462450} Committed: https://chromium.googlesource.com/chromium/src/+/d1950d5890181d178396d0be133d69a83066a84d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -237 lines) Patch
M content/browser/background_fetch/background_fetch_job_controller_unittest.cc View 5 chunks +8 lines, -108 lines 0 comments Download
M content/browser/background_fetch/background_fetch_service_unittest.cc View 6 chunks +2 lines, -129 lines 0 comments Download
M content/browser/background_fetch/background_fetch_test_base.h View 4 chunks +18 lines, -0 lines 0 comments Download
M content/browser/background_fetch/background_fetch_test_base.cc View 4 chunks +137 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
Peter Beverloo
+harkness
3 years, 8 months ago (2017-04-04 18:12:25 UTC) #2
harkness
lgtm
3 years, 8 months ago (2017-04-05 08:43:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796973002/1
3 years, 8 months ago (2017-04-06 12:31:22 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 13:29:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d1950d5890181d178396d0be133d...

Powered by Google App Engine
This is Rietveld 408576698