Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2796933003: Store BackgroundFetchRequestInfo in a refcounted pointer (Closed)

Created:
3 years, 8 months ago by Peter Beverloo
Modified:
3 years, 8 months ago
Reviewers:
harkness
CC:
chromium-reviews, Peter Beverloo, darin-cc_chromium.org, jam, harkness+watch_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Store BackgroundFetchRequestInfo in a refcounted pointer This'll significantly reduce data copies. I expect that we'll be able to store it in a std::unique_ptr<> when persistent storage is in place, so added a TODO to the header to migrate in due course. BUG= Review-Url: https://codereview.chromium.org/2796933003 Cr-Commit-Position: refs/heads/master@{#462033} Committed: https://chromium.googlesource.com/chromium/src/+/eed3ef23555fbc6e4c6ba8a5ed0e018116b311ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -97 lines) Patch
M content/browser/background_fetch/background_fetch_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/background_fetch/background_fetch_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/background_fetch/background_fetch_data_manager.h View 4 chunks +8 lines, -8 lines 0 comments Download
M content/browser/background_fetch/background_fetch_data_manager.cc View 11 chunks +35 lines, -32 lines 0 comments Download
M content/browser/background_fetch/background_fetch_data_manager_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/background_fetch/background_fetch_job_controller.h View 3 chunks +6 lines, -7 lines 0 comments Download
M content/browser/background_fetch/background_fetch_job_controller.cc View 7 chunks +22 lines, -18 lines 0 comments Download
M content/browser/background_fetch/background_fetch_job_controller_unittest.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M content/browser/background_fetch/background_fetch_request_info.h View 4 chunks +12 lines, -6 lines 0 comments Download
M content/browser/background_fetch/background_fetch_request_info.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/browser/background_fetch/background_fetch_service_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Peter Beverloo
+harkness
3 years, 8 months ago (2017-04-04 17:27:50 UTC) #6
harkness
lgtm
3 years, 8 months ago (2017-04-05 08:26:03 UTC) #7
harkness
lgtm
3 years, 8 months ago (2017-04-05 08:26:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796933003/1
3 years, 8 months ago (2017-04-05 10:59:22 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 11:04:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eed3ef23555fbc6e4c6ba8a5ed0e...

Powered by Google App Engine
This is Rietveld 408576698