Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: content/browser/background_fetch/background_fetch_data_manager.cc

Issue 2796953003: Populate the response blob for finished Background Fetches (Closed)
Patch Set: Populate the response blob for finished Background Fetches Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_data_manager.cc
diff --git a/content/browser/background_fetch/background_fetch_data_manager.cc b/content/browser/background_fetch/background_fetch_data_manager.cc
index 77919d87c29c1f7e18c579593bb5fd2b30ecc3b2..de20817b9fa00dedefddf050c1c93bcd1b93899b 100644
--- a/content/browser/background_fetch/background_fetch_data_manager.cc
+++ b/content/browser/background_fetch/background_fetch_data_manager.cc
@@ -205,31 +205,31 @@ void BackgroundFetchDataManager::GetSettledFetchesForRegistration(
BackgroundFetchSettledFetch settled_fetch;
settled_fetch.request = request->fetch_request();
- settled_fetch.response.url_list.push_back(request->GetURL());
+ settled_fetch.response.url_list = request->GetURLChain();
// TODO: settled_fetch.response.status_code
// TODO: settled_fetch.response.status_text
// TODO: settled_fetch.response.response_type
// TODO: settled_fetch.response.headers
- if (request->received_bytes() > 0) {
- DCHECK(!request->file_path().empty());
+ if (request->GetFileSize() > 0) {
+ DCHECK(!request->GetFilePath().empty());
std::unique_ptr<BlobHandle> blob_handle =
blob_storage_context_->CreateFileBackedBlob(
- request->file_path(), 0 /* offset */, request->received_bytes(),
+ request->GetFilePath(), 0 /* offset */, request->GetFileSize(),
base::Time() /* expected_modification_time */);
// TODO(peter): Appropriately handle !blob_handle
if (blob_handle) {
settled_fetch.response.blob_uuid = blob_handle->GetUUID();
- settled_fetch.response.blob_size = request->received_bytes();
+ settled_fetch.response.blob_size = request->GetFileSize();
blob_handles.push_back(std::move(blob_handle));
}
}
// TODO: settled_fetch.response.error
- // TODO: settled_fetch.response.response_time
+ settled_fetch.response.response_time = request->GetResponseTime();
// TODO: settled_fetch.response.cors_exposed_header_names
settled_fetches.push_back(settled_fetch);

Powered by Google App Engine
This is Rietveld 408576698