color: Clean up dependencies to allow including in cc/paint

color: Clean up dependencies to allow including in cc/paint

Move color_space.cc and some related functionality into gfx:color_space,
so that they can be included in cc/paint without creating a dependency
cycle.

Also shrink some of the struct sizes and add a hash function, as these
will be helpful in future patches.

BUG=701942
Review-Url: https://codereview.chromium.org/2795093002
Cr-Commit-Position: refs/heads/master@{#461770}
Committed: https://chromium.googlesource.com/chromium/src/+/77f3b241fc87c2a925ba8d0da94cc97667abc32c

[ccameron, 2017-04-03 23:32:15]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 23:33:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-04-03 23:33:43]

ccameron@chromium.org changed reviewers:
+ msarett@google.com

[ccameron, 2017-04-03 23:33:43]

Minor tweaks here, going towards the bigger patch in

https://codereview.chromium.org/2795093002

[commit-bot: I haz the power, 2017-04-04 00:24:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 00:24:23]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[ccameron, 2017-04-04 00:37:41]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 00:38:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 02:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 02:00:45]

Dry run: This issue passed the CQ dry run.

[msarett1, 2017-04-04 12:55:37]

msarett@chromium.org changed reviewers:
+ msarett@chromium.org

[msarett1, 2017-04-04 12:55:38]

lgtm

[ccameron, 2017-04-04 17:32:03]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-04-04 17:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 18:16:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491327123638370,
"parent_rev": "6d1a7f6758769bb73a40ff8b8d21aa3b580a4926", "commit_rev":
"77f3b241fc87c2a925ba8d0da94cc97667abc32c"}

[commit-bot: I haz the power, 2017-04-04 18:17:23]

Description was changed from

==========
color: Clean up dependencies to allow including in cc/paint

Move color_space.cc and some related functionality into gfx:color_space,
so that they can be included in cc/paint without creating a dependency
cycle.

Also shrink some of the struct sizes and add a hash function, as these
will be helpful in future patches.

BUG=701942
==========

to

==========
color: Clean up dependencies to allow including in cc/paint

Move color_space.cc and some related functionality into gfx:color_space,
so that they can be included in cc/paint without creating a dependency
cycle.

Also shrink some of the struct sizes and add a hash function, as these
will be helpful in future patches.

BUG=701942

Review-Url: https://codereview.chromium.org/2795093002
Cr-Commit-Position: refs/heads/master@{#461770}
Committed:
https://chromium.googlesource.com/chromium/src/+/77f3b241fc87c2a925ba8d0da94c...
==========

[commit-bot: I haz the power, 2017-04-04 18:17:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/77f3b241fc87c2a925ba8d0da94c...

[Nico, 2017-05-19 21:01:49]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-05-19 21:01:50]

https://codereview.chromium.org/2795093002/diff/20001/ui/gfx/BUILD.gn
File ui/gfx/BUILD.gn (right):

https://codereview.chromium.org/2795093002/diff/20001/ui/gfx/BUILD.gn#newcode414
ui/gfx/BUILD.gn:414: defines = [ "GFX_IMPLEMENTATION" ]
This does not lgtm. You now have two components both setting GFX_IMPLEMENTATION,
which means things in deps (like switches_sources, which you added in
https://codereview.chromium.org/2877093002) now have definitions in both .sos.
Please create a dedicated _IMPLEMENTATION file for this, a dedicated _EXPORT
thing for this, and make it depend on the gfx component, or make
switches_sources use your new _EXPORT and make gfx depend on this component.

See
https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md
for more information on the component build.