Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2877093002: color: Add command line flag to force output color space (Closed)

Created:
3 years, 7 months ago by ccameron
Modified:
3 years, 7 months ago
Reviewers:
hubbe
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Add command line flag to force output color space This will be used by layout tests (in particular, Mac right now is using Apple's GenericRGB space, but will be moved to BT2020 primaries with a gamma 1.8 transfer function, for a greater contrast with sRGB). This is also really helpful for debugging. BUG=713891 Review-Url: https://codereview.chromium.org/2877093002 Cr-Commit-Position: refs/heads/master@{#471601} Committed: https://chromium.googlesource.com/chromium/src/+/290a91a1ba67abcef76dda7e43fd80323ed1c110

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Total comments: 2

Patch Set 3 : Fix type #

Patch Set 4 : Add windows fix #

Patch Set 5 : Fix windows again #

Patch Set 6 : Fix windows again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -1 line) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/color_space.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gfx/color_space.cc View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M ui/gfx/color_space_win.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gfx/icc_profile.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/icc_profile.cc View 2 chunks +33 lines, -0 lines 0 comments Download
M ui/gfx/icc_profile_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/icc_profile_unittest.cc View 1 2 chunks +19 lines, -1 line 0 comments Download
M ui/gfx/icc_profile_win.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/icc_profile_x11.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (21 generated)
ccameron
ptal I've decided on BT2020+gamma1.8 for the Mac layout tests, because it's a lot harder ...
3 years, 7 months ago (2017-05-12 16:34:03 UTC) #2
hubbe
lgtm https://codereview.chromium.org/2877093002/diff/1/ui/gfx/color_space.cc File ui/gfx/color_space.cc (right): https://codereview.chromium.org/2877093002/diff/1/ui/gfx/color_space.cc#newcode400 ui/gfx/color_space.cc:400: // in case we somhow get an id ...
3 years, 7 months ago (2017-05-12 17:23:06 UTC) #5
ccameron
https://codereview.chromium.org/2877093002/diff/1/ui/gfx/color_space.cc File ui/gfx/color_space.cc (right): https://codereview.chromium.org/2877093002/diff/1/ui/gfx/color_space.cc#newcode400 ui/gfx/color_space.cc:400: // in case we somhow get an id which ...
3 years, 7 months ago (2017-05-12 20:45:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877093002/20001
3 years, 7 months ago (2017-05-12 20:47:05 UTC) #11
Avi (use Gerrit)
https://codereview.chromium.org/2877093002/diff/20001/ui/gfx/color_space.cc File ui/gfx/color_space.cc (right): https://codereview.chromium.org/2877093002/diff/20001/ui/gfx/color_space.cc#newcode400 ui/gfx/color_space.cc:400: // in case we somhow get an id which ...
3 years, 7 months ago (2017-05-12 21:06:32 UTC) #12
ccameron
https://codereview.chromium.org/2877093002/diff/20001/ui/gfx/color_space.cc File ui/gfx/color_space.cc (right): https://codereview.chromium.org/2877093002/diff/20001/ui/gfx/color_space.cc#newcode400 ui/gfx/color_space.cc:400: // in case we somhow get an id which ...
3 years, 7 months ago (2017-05-12 21:46:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877093002/40001
3 years, 7 months ago (2017-05-12 21:47:56 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/227698)
3 years, 7 months ago (2017-05-12 23:11:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877093002/40001
3 years, 7 months ago (2017-05-13 04:31:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/227894)
3 years, 7 months ago (2017-05-13 06:09:18 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877093002/60001
3 years, 7 months ago (2017-05-13 09:08:43 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/443859)
3 years, 7 months ago (2017-05-13 10:01:21 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877093002/60001
3 years, 7 months ago (2017-05-13 16:41:27 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877093002/20002
3 years, 7 months ago (2017-05-13 18:06:02 UTC) #33
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 19:22:48 UTC) #36
Message was sent while issue was closed.
Committed patchset #6 (id:20002) as
https://chromium.googlesource.com/chromium/src/+/290a91a1ba67abcef76dda7e43fd...

Powered by Google App Engine
This is Rietveld 408576698