color: Add command line flag to force output color space

color: Add command line flag to force output color space

This will be used by layout tests (in particular, Mac right now is using
Apple's GenericRGB space, but will be moved to BT2020 primaries with a
gamma 1.8 transfer function, for a greater contrast with sRGB).

This is also really helpful for debugging.

BUG=713891
Review-Url: https://codereview.chromium.org/2877093002
Cr-Commit-Position: refs/heads/master@{#471601}
Committed: https://chromium.googlesource.com/chromium/src/+/290a91a1ba67abcef76dda7e43fd80323ed1c110

[ccameron, 2017-05-12 16:34:03]

ccameron@chromium.org changed reviewers:
+ hubbe@chromium.org

[ccameron, 2017-05-12 16:34:03]

ptal

I've decided on BT2020+gamma1.8 for the Mac layout tests, because it's a lot
harder to mistake for sRGB (unlike the "generic RGB" profile currently used,
which can easily be mistaken for rounding error). I was thinking to do
XYZ+linear (for even more contrast), but that space would likely hide bugs
(cause we use it as an intermediate so often).

[ccameron, 2017-05-12 16:34:06]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 16:35:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2017-05-12 17:23:06]

lgtm

https://codereview.chromium.org/2877093002/diff/1/ui/gfx/color_space.cc
File ui/gfx/color_space.cc (right):

https://codereview.chromium.org/2877093002/diff/1/ui/gfx/color_space.cc#newco...
ui/gfx/color_space.cc:400: // in case we somhow get an id which is not listed in
the switch.
+e

https://codereview.chromium.org/2877093002/diff/1/ui/gfx/switches.cc
File ui/gfx/switches.cc (right):

https://codereview.chromium.org/2877093002/diff/1/ui/gfx/switches.cc#newcode30
ui/gfx/switches.cc:30: // layout tests) and "bt2020-gamma18" (to be used by Mac
layout tests in the
Can we just use it for *all* layout tests?

[commit-bot: I haz the power, 2017-05-12 17:28:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 17:28:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2017-05-12 20:45:51]

https://codereview.chromium.org/2877093002/diff/1/ui/gfx/color_space.cc
File ui/gfx/color_space.cc (right):

https://codereview.chromium.org/2877093002/diff/1/ui/gfx/color_space.cc#newco...
ui/gfx/color_space.cc:400: // in case we somhow get an id which is not listed in
the switch.
On 2017/05/12 17:23:06, hubbe wrote:
> +e

Done.

https://codereview.chromium.org/2877093002/diff/1/ui/gfx/switches.cc
File ui/gfx/switches.cc (right):

https://codereview.chromium.org/2877093002/diff/1/ui/gfx/switches.cc#newcode30
ui/gfx/switches.cc:30: // layout tests) and "bt2020-gamma18" (to be used by Mac
layout tests in the
On 2017/05/12 17:23:06, hubbe wrote:
> Can we just use it for *all* layout tests?

To think of it, I think you're right -- we should try to make all platforms
match (or nearly match).

I'm going to start with Mac though, cause it's already the odd one out.

[ccameron, 2017-05-12 20:46:00]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-12 20:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/2877093002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2017-05-12 20:47:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-05-12 21:06:32]

https://codereview.chromium.org/2877093002/diff/20001/ui/gfx/color_space.cc
File ui/gfx/color_space.cc (right):

https://codereview.chromium.org/2877093002/diff/20001/ui/gfx/color_space.cc#n...
ui/gfx/color_space.cc:400: // in case we somhow get an id which is not listed in
the switch.
typo :(

[ccameron, 2017-05-12 21:41:32]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2017-05-12 21:46:19]

https://codereview.chromium.org/2877093002/diff/20001/ui/gfx/color_space.cc
File ui/gfx/color_space.cc (right):

https://codereview.chromium.org/2877093002/diff/20001/ui/gfx/color_space.cc#n...
ui/gfx/color_space.cc:400: // in case we somhow get an id which is not listed in
the switch.
On 2017/05/12 21:06:32, Avi (ping after 24h) wrote:
> typo :(

Got it this time!

[ccameron, 2017-05-12 21:46:23]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-12 21:46:23]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/2877093002/#ps40001
(title: "Fix type")

[commit-bot: I haz the power, 2017-05-12 21:47:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 23:11:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 23:11:24]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[ccameron, 2017-05-13 04:30:48]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-05-13 04:31:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 06:09:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 06:09:18]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[ccameron, 2017-05-13 09:08:31]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-13 09:08:31]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/2877093002/#ps60001
(title: "Add windows fix")

[commit-bot: I haz the power, 2017-05-13 09:08:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 10:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 10:01:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ccameron, 2017-05-13 16:41:07]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-05-13 16:41:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-05-13 18:05:44]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-05-13 18:05:44]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/2877093002/#ps20002
(title: "Fix windows again")

[commit-bot: I haz the power, 2017-05-13 18:06:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 19:22:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20002, "attempt_start_ts": 1494698744427260,
"parent_rev": "d6bd864741d33ff3726227ab5dc688377c1b350e", "commit_rev":
"290a91a1ba67abcef76dda7e43fd80323ed1c110"}

[commit-bot: I haz the power, 2017-05-13 19:22:47]

Description was changed from

==========
color: Add command line flag to force output color space

This will be used by layout tests (in particular, Mac right now is using
Apple's GenericRGB space, but will be moved to BT2020 primaries with a
gamma 1.8 transfer function, for a greater contrast with sRGB).

This is also really helpful for debugging.

BUG=713891
==========

to

==========
color: Add command line flag to force output color space

This will be used by layout tests (in particular, Mac right now is using
Apple's GenericRGB space, but will be moved to BT2020 primaries with a
gamma 1.8 transfer function, for a greater contrast with sRGB).

This is also really helpful for debugging.

BUG=713891

Review-Url: https://codereview.chromium.org/2877093002
Cr-Commit-Position: refs/heads/master@{#471601}
Committed:
https://chromium.googlesource.com/chromium/src/+/290a91a1ba67abcef76dda7e43fd...
==========

[commit-bot: I haz the power, 2017-05-13 19:22:48]

Committed patchset #6 (id:20002) as
https://chromium.googlesource.com/chromium/src/+/290a91a1ba67abcef76dda7e43fd...