Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: ui/gfx/BUILD.gn

Issue 2795093002: color: Clean up dependencies to allow including in cc/paint (Closed)
Patch Set: Move to separate component Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/color_space.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/BUILD.gn
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn
index 77856daaebfd8aa9f696e607f225f420d9548155..35437024103200e9345d3cb15ee8f1bc17721229 100644
--- a/ui/gfx/BUILD.gn
+++ b/ui/gfx/BUILD.gn
@@ -53,7 +53,6 @@ component("gfx") {
"color_analysis.cc",
"color_analysis.h",
"color_palette.h",
- "color_space.cc",
"color_space_win.cc",
"color_space_win.h",
"color_transform.cc",
@@ -88,8 +87,6 @@ component("gfx") {
"gfx_paths.h",
"half_float.cc",
"half_float.h",
- "icc_profile.cc",
- "icc_profile.h",
"icc_profile_mac.mm",
"icc_profile_win.cc",
"icc_profile_x11.cc",
@@ -165,8 +162,6 @@ component("gfx") {
"shadow_value.h",
"skbitmap_operations.cc",
"skbitmap_operations.h",
- "skia_color_space_util.cc",
- "skia_color_space_util.h",
"switches.cc",
"switches.h",
"sys_color_change_listener.cc",
@@ -398,19 +393,25 @@ component("gfx") {
}
}
-# Depend on this to use color_space.h without pulling in all of gfx.
-source_set("color_space") {
+component("color_space") {
sources = [
+ "color_space.cc",
"color_space.h",
+ "icc_profile.cc",
+ "icc_profile.h",
+ "skia_color_space_util.cc",
+ "skia_color_space_util.h",
]
-
- defines = [ "GFX_IMPLEMENTATION" ]
-
public_deps = [
":gfx_export",
"//base",
"//skia",
]
+ deps = [
+ "//base",
+ "//skia",
+ ]
+ defines = [ "GFX_IMPLEMENTATION" ]
Nico 2017/05/19 21:01:50 This does not lgtm. You now have two components bo
}
# Depend on this to use half_float.h without pulling in all of gfx.
« no previous file with comments | « no previous file | ui/gfx/color_space.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698