color: Clean up dependencies to allow including in cc/paint

ui/gfx/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 import("//testing/libfuzzer/fuzzer_test.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
@@ skipping 35 matching lines @@
     "android/gfx_jni_registrar.cc",
     "android/gfx_jni_registrar.h",
     "android/java_bitmap.cc",
     "android/java_bitmap.h",
     "android/view_configuration.cc",
     "android/view_configuration.h",
     "break_list.h",
     "color_analysis.cc",
     "color_analysis.h",
     "color_palette.h",
-    "color_space.cc",
     "color_space_win.cc",
     "color_space_win.h",
     "color_transform.cc",
     "color_transform.h",
     "color_utils.cc",
     "color_utils.h",
     "decorated_text.cc",
     "decorated_text.h",
     "favicon_size.cc",
     "favicon_size.h",
@@ skipping 14 matching lines @@
     "font_render_params_android.cc",
     "font_render_params_linux.cc",
     "font_render_params_mac.cc",
     "font_render_params_win.cc",
     "gdi_util.cc",
     "gdi_util.h",
     "gfx_paths.cc",
     "gfx_paths.h",
     "half_float.cc",
     "half_float.h",
-    "icc_profile.cc",
-    "icc_profile.h",
     "icc_profile_mac.mm",
     "icc_profile_win.cc",
     "icc_profile_x11.cc",
     "icon_util.cc",
     "icon_util.h",
     "image/image.cc",
     "image/image.h",
     "image/image_family.cc",
     "image/image_family.h",
     "image/image_ios.mm",
@@ skipping 55 matching lines @@
     "scrollbar_size.cc",
     "scrollbar_size.h",
     "selection_model.cc",
     "selection_model.h",
     "sequential_id_generator.cc",
     "sequential_id_generator.h",
     "shadow_value.cc",
     "shadow_value.h",
     "skbitmap_operations.cc",
     "skbitmap_operations.h",
-    "skia_color_space_util.cc",
-    "skia_color_space_util.h",
     "switches.cc",
     "switches.h",
     "sys_color_change_listener.cc",
     "sys_color_change_listener.h",
     "text_constants.h",
     "text_elider.cc",
     "text_elider.h",
     "text_utils.cc",
     "text_utils.h",
     "text_utils_android.cc",
@@ skipping 211 matching lines @@
       "icc_profile_x11.cc",
       "path_x11.cc",
     ]
   }
 
   if (use_cairo) {
     configs += [ "//build/config/linux/pangocairo" ]
   }
 }
 
-# Depend on this to use color_space.h without pulling in all of gfx.
-source_set("color_space") {
+component("color_space") {
   sources = [
+    "color_space.cc",
     "color_space.h",
+    "icc_profile.cc",
+    "icc_profile.h",
+    "skia_color_space_util.cc",
+    "skia_color_space_util.h",
   ]
-
-  defines = [ "GFX_IMPLEMENTATION" ]
-
   public_deps = [
     ":gfx_export",
     "//base",
     "//skia",
   ]
+  deps = [
+    "//base",
+    "//skia",
+  ]
+  defines = [ "GFX_IMPLEMENTATION" ]

[Nico, 2017/05/19 21:01:50]

This does not lgtm. You now have two components both setting GFX_IMPLEMENTATION,
which means things in deps (like switches_sources, which you added in
https://codereview.chromium.org/2877093002) now have definitions in both .sos.
Please create a dedicated _IMPLEMENTATION file for this, a dedicated _EXPORT
thing for this, and make it depend on the gfx component, or make
switches_sources use your new _EXPORT and make gfx depend on this component.

See
https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md
for more information on the component build.

 }
 
 # Depend on this to use half_float.h without pulling in all of gfx.
 source_set("half_float") {
   sources = [
     "half_float.h",
   ]
 
   defines = [ "GFX_IMPLEMENTATION" ]
 
@@ skipping 336 matching lines @@
 
 fuzzer_test("color_transform_fuzztest") {
   sources = [
     "color_transform_fuzzer.cc",
   ]
   deps = [
     ":gfx",
   ]
   libfuzzer_options = [ "max_len=1024" ]
 }