Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 2793843002: Generalise 'flag' template to 'primitive' when generating ComputedStyle. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generalise 'flag' template to 'primitive' when generating ComputedStyle. Currently we have 'flag' fields which represent boolean fields inside ComputedStyle. We can generalise this to not only booleans, but any primitive value such as int or float. This patch renames the 'flag' template to 'primitive' and adds a special case for 'bool' fields which allows them to be packed as a single bit. This is prework for generating fields that are stored as ints or floats. This patch does not affect generated code. BUG=628043 Review-Url: https://codereview.chromium.org/2793843002 Cr-Commit-Position: refs/heads/master@{#462344} Committed: https://chromium.googlesource.com/chromium/src/+/e8890d72e9824fce593382d5eb23210e4d7db177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/build/scripts/templates/fields/flag.tmpl View 1 chunk +0 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/build/scripts/templates/fields/primitive.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (13 generated)
shend
Hi Naina, PTAL :)
3 years, 8 months ago (2017-04-03 01:04:55 UTC) #2
nainar
lgtm
3 years, 8 months ago (2017-04-04 20:51:00 UTC) #3
shend
Hi Alan, PTAL for owners.
3 years, 8 months ago (2017-04-04 23:44:11 UTC) #5
alancutter (OOO until 2018)
lgtm
3 years, 8 months ago (2017-04-05 04:41:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793843002/1
3 years, 8 months ago (2017-04-06 03:29:03 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 03:35:30 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8890d72e9824fce593382d5eb23...

Powered by Google App Engine
This is Rietveld 408576698