Generate ComputedStyle::hasViewportUnits and hasRemUnits.

Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasRemUnits is generated as a monotonic_flag field, but
hasViewportUnits needs to be a boolean flag field because there are
places where it gets set to false.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2797963002
Cr-Commit-Position: refs/heads/master@{#462377}
Committed: https://chromium.googlesource.com/chromium/src/+/25809e1270b9eb4103f1efcc089c781df8465e39

[shend, 2017-04-05 08:10:10]

Description was changed from

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

BUG=628043
==========

to

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

[shend, 2017-04-05 08:10:44]

The CQ bit was checked by shend@chromium.org

[shend, 2017-04-05 08:10:47]

The CQ bit was unchecked by shend@chromium.org

[shend, 2017-04-05 08:10:58]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-04-05 08:10:58]

Hi Naina, PTAL :)

[nainar, 2017-04-05 16:41:49]

lgtm with two small questions.

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:55: {'name':
'HasViewportUnits', 'field_template': 'flag', 'default_value': 'false',
why isnt it a monotonic flag for my own understanding?

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:348: m_hasRemUnits =
other.hasRemUnits();
why can't we use setHasRemUnits() here instead?

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:348: m_hasRemUnits =
other.hasRemUnits();
why can't we use setHasRemUnits() here instead?

[shend, 2017-04-05 22:32:26]

Description was changed from

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

to

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasViewportUnits is generated as a monotonic_flag field, but
hasRemUnits needs to be a flag field because of a hack in the code
discussed in https://codereview.chromium.org/2767853002.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

[shend, 2017-04-05 22:32:37]

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:55: {'name':
'HasViewportUnits', 'field_template': 'flag', 'default_value': 'false',
On 2017/04/05 at 16:41:49, nainar wrote:
> why isnt it a monotonic flag for my own understanding?

Good question. setHasViewportUnits currently takes a boolean argument because of
a hack discussed in https://codereview.chromium.org/2767853002. I'll update the
CL description.

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:348: m_hasRemUnits =
other.hasRemUnits();
On 2017/04/05 at 16:41:49, nainar wrote:
> why can't we use setHasRemUnits() here instead?

Since it is a monotonic flag, the setter doesn't take an argument and only sets
hasRemUnits to true.

This affects your work because this will break if hasRemUnits changes groups. I
have an idea about generating private accessors for all members which we can
discuss offline. That should just allow you to do
setHasRemUnits(other.HasRemUnits()).

[shend, 2017-04-05 22:33:43]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-04-05 22:33:44]

Hi Alan, PTAL

[alancutter (OOO until 2018), 2017-04-06 04:18:49]

lgtm

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:55: {'name':
'HasViewportUnits', 'field_template': 'flag', 'default_value': 'false',
On 2017/04/05 at 22:32:36, shend wrote:
> On 2017/04/05 at 16:41:49, nainar wrote:
> > why isnt it a monotonic flag for my own understanding?
> 
> Good question. setHasViewportUnits currently takes a boolean argument because
of a hack discussed in https://codereview.chromium.org/2767853002. I'll update
the CL description.

I don't think this "hack" is the reason it's not a monotonic_flag. The reason is
because some places sets it false. Also your updated description has the two
fields backwards in this regard.

[shend, 2017-04-06 04:26:54]

Description was changed from

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasViewportUnits is generated as a monotonic_flag field, but
hasRemUnits needs to be a flag field because of a hack in the code
discussed in https://codereview.chromium.org/2767853002.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

to

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasViewportUnits is generated as a monotonic_flag field, but
hasRemUnits needs to be a flag field because there are places
where it gets set to false.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

[shend, 2017-04-06 04:27:29]

Description was changed from

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasViewportUnits is generated as a monotonic_flag field, but
hasRemUnits needs to be a flag field because there are places
where it gets set to false.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

to

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasRemUnits is generated as a monotonic_flag field, but
hasViewportUnits needs to be a flag field because there are places
where it gets set to false.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

[shend, 2017-04-06 04:27:42]

On 2017/04/06 at 04:18:49, alancutter wrote:
> lgtm
> 
>
https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):
> 
>
https://codereview.chromium.org/2797963002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/build/scripts/make_computed_style_base.py:55:
{'name': 'HasViewportUnits', 'field_template': 'flag', 'default_value': 'false',
> On 2017/04/05 at 22:32:36, shend wrote:
> > On 2017/04/05 at 16:41:49, nainar wrote:
> > > why isnt it a monotonic flag for my own understanding?
> > 
> > Good question. setHasViewportUnits currently takes a boolean argument
because of a hack discussed in https://codereview.chromium.org/2767853002. I'll
update the CL description.
> 
> I don't think this "hack" is the reason it's not a monotonic_flag. The reason
is because some places sets it false. Also your updated description has the two
fields backwards in this regard.

Thanks for spotting those :)

[shend, 2017-04-06 04:27:57]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 04:28:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 04:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 04:38:24]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[shend, 2017-04-06 04:44:16]

Description was changed from

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasRemUnits is generated as a monotonic_flag field, but
hasViewportUnits needs to be a flag field because there are places
where it gets set to false.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

to

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasRemUnits is generated as a monotonic_flag field, but
hasViewportUnits needs to be a boolean flag field because there are
places where it gets set to false.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

[shend, 2017-04-06 04:48:31]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 04:48:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 04:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 04:50:43]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-04-06 04:54:23]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 04:54:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 06:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 06:37:23]

Dry run: This issue passed the CQ dry run.

[shend, 2017-04-06 06:42:54]

The CQ bit was checked by shend@chromium.org

[shend, 2017-04-06 06:42:55]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2797963002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-06 06:47:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 06:58:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491460974937870,
"parent_rev": "b0a7f41f21e310fb708a01ea0cdf81816d4df386", "commit_rev":
"25809e1270b9eb4103f1efcc089c781df8465e39"}

[commit-bot: I haz the power, 2017-04-06 06:59:03]

Description was changed from

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasRemUnits is generated as a monotonic_flag field, but
hasViewportUnits needs to be a boolean flag field because there are
places where it gets set to false.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043
==========

to

==========
Generate ComputedStyle::hasViewportUnits and hasRemUnits.

This patch moves hasViewportUnits and hasRemUnits to be generated in
ComputedStyleBase. Both are noninherited nonproperties.

hasRemUnits is generated as a monotonic_flag field, but
hasViewportUnits needs to be a boolean flag field because there are
places where it gets set to false.

Since these are the two remaining noninherited fields stored directly
in ComputedStyle, this patch also removes the NonInheritedData struct
from ComputedStyle.

Diff of generated files:
https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2797963002
Cr-Commit-Position: refs/heads/master@{#462377}
Committed:
https://chromium.googlesource.com/chromium/src/+/25809e1270b9eb4103f1efcc089c...
==========

[commit-bot: I haz the power, 2017-04-06 06:59:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/25809e1270b9eb4103f1efcc089c...

[shend, 2017-04-20 06:37:30]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2828193002/ by shend@chromium.org.

The reason for reverting is: testing
https://bugs.chromium.org/p/chromium/issues/detail?id=713128.