Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.json5

Issue 2793843002: Generalise 'flag' template to 'primitive' when generating ComputedStyle. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSProperties.json5
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.json5 b/third_party/WebKit/Source/core/css/CSSProperties.json5
index 338b1076d25ff3efd8fe68d63442af07a9da808e..c4dc6586590bdb3ae5eded927b4036ef1c5ea258 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.json5
+++ b/third_party/WebKit/Source/core/css/CSSProperties.json5
@@ -69,9 +69,9 @@
valid_values: [
// Field is stored as an enum and has a initial/getter/setter/resetter.
"keyword",
- // Field is stored a packed boolean flag and has a initial/getter/setter/resetter.
- // TODO(shend): generalise this to "primitive"
- "flag",
+ // Field stores a primitive value like int/bool. The type is specified by
+ // type_name. The interface has a initial/getter/setter/resetter.
+ "primitive",
// Field is stored as a bool, whose default value is false
// and can only be set to true. Has a initial/getter/setter.
"monotonic_flag",
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698