Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSProperties.json5

Issue 2793843002: Generalise 'flag' template to 'primitive' when generating ComputedStyle. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 // This file specifies all the CSS properties we support and the necessary 2 // This file specifies all the CSS properties we support and the necessary
3 // information for our code generation. The various supported arguments 3 // information for our code generation. The various supported arguments
4 // are described below with example usage 4 // are described below with example usage
5 5
6 parameters: { 6 parameters: {
7 // - alias_for: "other-property" 7 // - alias_for: "other-property"
8 // Properties specifying alias_for should be virtually identical to the 8 // Properties specifying alias_for should be virtually identical to the
9 // properties they alias. Minor parsing differences are allowed as long as 9 // properties they alias. Minor parsing differences are allowed as long as
10 // the CSSValues created are of the same format of the aliased property. 10 // the CSSValues created are of the same format of the aliased property.
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 }, 62 },
63 63
64 // - field_template 64 // - field_template
65 // Affects how the interface to this field is generated. 65 // Affects how the interface to this field is generated.
66 // TODO(sashab, meade): Remove this once TypedOM types are specified for 66 // TODO(sashab, meade): Remove this once TypedOM types are specified for
67 // every property, since this value can be inferred from that. 67 // every property, since this value can be inferred from that.
68 field_template: { 68 field_template: {
69 valid_values: [ 69 valid_values: [
70 // Field is stored as an enum and has a initial/getter/setter/resetter. 70 // Field is stored as an enum and has a initial/getter/setter/resetter.
71 "keyword", 71 "keyword",
72 // Field is stored a packed boolean flag and has a initial/getter/setter /resetter. 72 // Field stores a primitive value like int/bool. The type is specified b y
73 // TODO(shend): generalise this to "primitive" 73 // type_name. The interface has a initial/getter/setter/resetter.
74 "flag", 74 "primitive",
75 // Field is stored as a bool, whose default value is false 75 // Field is stored as a bool, whose default value is false
76 // and can only be set to true. Has a initial/getter/setter. 76 // and can only be set to true. Has a initial/getter/setter.
77 "monotonic_flag", 77 "monotonic_flag",
78 // Field has type specified at field_type_path and has a getter/setter. 78 // Field has type specified at field_type_path and has a getter/setter.
79 // Also has a setter taking an rvalue reference. Cannot be packed. 79 // Also has a setter taking an rvalue reference. Cannot be packed.
80 "external", 80 "external",
81 ], 81 ],
82 }, 82 },
83 83
84 // - field_type_path: "path/to/Type" 84 // - field_type_path: "path/to/Type"
(...skipping 3086 matching lines...) Expand 10 before | Expand all | Expand 10 after
3171 { 3171 {
3172 name: "-webkit-transition-timing-function", 3172 name: "-webkit-transition-timing-function",
3173 alias_for: "transition-timing-function", 3173 alias_for: "transition-timing-function",
3174 }, 3174 },
3175 { 3175 {
3176 name: "-webkit-user-select", 3176 name: "-webkit-user-select",
3177 alias_for: "user-select", 3177 alias_for: "user-select",
3178 }, 3178 },
3179 ], 3179 ],
3180 } 3180 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698