Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 2793093002: [InputEvent] Update spec link for StaticRange.idl and use unsigned offset (Closed)

Created:
3 years, 8 months ago by chongz
Modified:
3 years, 8 months ago
Reviewers:
foolip
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Update spec link for StaticRange.idl and use unsigned offset This CL: 1. Add link to latest spec in StaticRange.idl * https://garykac.github.io/staticrange/#interface-staticrange 2. Replace |int start/endOffset| with |unsigned start/endOffset| to match spec BUG=707913 Review-Url: https://codereview.chromium.org/2793093002 Cr-Commit-Position: refs/heads/master@{#461725} Committed: https://chromium.googlesource.com/chromium/src/+/b3279fff89f248e0bf264586cc2c71f19d97de40

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -60 lines) Patch
M third_party/WebKit/Source/core/dom/StaticRange.h View 4 chunks +12 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StaticRange.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StaticRange.idl View 2 chunks +5 lines, -5 lines 3 comments Download
M third_party/WebKit/Source/core/dom/StaticRangeTest.cpp View 6 chunks +33 lines, -33 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
chongz
foolip@ PTAL, thanks!
3 years, 8 months ago (2017-04-03 20:45:15 UTC) #6
foolip
lgtm https://codereview.chromium.org/2793093002/diff/1/third_party/WebKit/Source/core/dom/StaticRange.idl File third_party/WebKit/Source/core/dom/StaticRange.idl (right): https://codereview.chromium.org/2793093002/diff/1/third_party/WebKit/Source/core/dom/StaticRange.idl#newcode22 third_party/WebKit/Source/core/dom/StaticRange.idl:22: [NewObject, RaisesException] Range toRange(); The spec never throws ...
3 years, 8 months ago (2017-04-04 04:17:12 UTC) #9
chongz
https://codereview.chromium.org/2793093002/diff/1/third_party/WebKit/Source/core/dom/StaticRange.idl File third_party/WebKit/Source/core/dom/StaticRange.idl (right): https://codereview.chromium.org/2793093002/diff/1/third_party/WebKit/Source/core/dom/StaticRange.idl#newcode22 third_party/WebKit/Source/core/dom/StaticRange.idl:22: [NewObject, RaisesException] Range toRange(); On 2017/04/04 04:17:12, foolip_UTC7 wrote: ...
3 years, 8 months ago (2017-04-04 15:22:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793093002/1
3 years, 8 months ago (2017-04-04 15:23:23 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b3279fff89f248e0bf264586cc2c71f19d97de40
3 years, 8 months ago (2017-04-04 15:28:33 UTC) #15
foolip
3 years, 8 months ago (2017-04-04 16:10:53 UTC) #16
Message was sent while issue was closed.
https://codereview.chromium.org/2793093002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/StaticRange.idl (right):

https://codereview.chromium.org/2793093002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/StaticRange.idl:22: [NewObject,
RaisesException] Range toRange();
On 2017/04/04 15:22:32, chongz wrote:
> On 2017/04/04 04:17:12, foolip_UTC7 wrote:
> > The spec never throws an exception, can you investigate?
> 
> It relies on |Range::setStart()| and |Range::setEnd()| which throws exception.
> 
> I noticed that Range's spec (https://dom.spec.whatwg.org/#interface-range)
> doesn't throw exception, it that a bug as well?

I've filed https://github.com/garykac/staticrange/issues/4

DOM does throw exceptions in https://dom.spec.whatwg.org/#concept-range-bp-set,
are there others that are thrown by Blink but not covered by the spec?

Powered by Google App Engine
This is Rietveld 408576698