Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/core/dom/StaticRange.cpp

Issue 2793093002: [InputEvent] Update spec link for StaticRange.idl and use unsigned offset (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/StaticRange.cpp
diff --git a/third_party/WebKit/Source/core/dom/StaticRange.cpp b/third_party/WebKit/Source/core/dom/StaticRange.cpp
index c763d1803982211ad652930c444badae4de4bb23..5ed4ed9736d51d2c4488d680aecf737c721c07a2 100644
--- a/third_party/WebKit/Source/core/dom/StaticRange.cpp
+++ b/third_party/WebKit/Source/core/dom/StaticRange.cpp
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
-
#include "core/dom/StaticRange.h"
#include "bindings/core/v8/ExceptionState.h"
@@ -16,27 +14,27 @@ namespace blink {
StaticRange::StaticRange(Document& document)
: m_ownerDocument(document),
m_startContainer(document),
- m_startOffset(0),
+ m_startOffset(0u),
m_endContainer(document),
- m_endOffset(0) {}
+ m_endOffset(0u) {}
StaticRange::StaticRange(Document& document,
Node* startContainer,
- int startOffset,
+ unsigned startOffset,
Node* endContainer,
- int endOffset)
+ unsigned endOffset)
: m_ownerDocument(document),
m_startContainer(startContainer),
m_startOffset(startOffset),
m_endContainer(endContainer),
m_endOffset(endOffset) {}
-void StaticRange::setStart(Node* container, int offset) {
+void StaticRange::setStart(Node* container, unsigned offset) {
m_startContainer = container;
m_startOffset = offset;
}
-void StaticRange::setEnd(Node* container, int offset) {
+void StaticRange::setEnd(Node* container, unsigned offset) {
m_endContainer = container;
m_endOffset = offset;
}

Powered by Google App Engine
This is Rietveld 408576698