Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Side by Side Diff: third_party/WebKit/Source/core/dom/StaticRange.idl

Issue 2793093002: [InputEvent] Update spec link for StaticRange.idl and use unsigned offset (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range- for-new-apis/1472 5 // https://garykac.github.io/staticrange/#interface-staticrange
6 6
7 [ 7 [
8 Constructor, 8 Constructor,
9 ConstructorCallWith=Document, 9 ConstructorCallWith=Document,
10 Exposed=Window, 10 Exposed=Window,
11 RuntimeEnabled=InputEvent, 11 RuntimeEnabled=InputEvent,
12 ] interface StaticRange { 12 ] interface StaticRange {
13 attribute Node startContainer; 13 attribute Node startContainer;
14 attribute long startOffset; 14 attribute unsigned long startOffset;
15 attribute Node endContainer; 15 attribute Node endContainer;
16 attribute long endOffset; 16 attribute unsigned long endOffset;
17 readonly attribute boolean collapsed; 17 readonly attribute boolean collapsed;
18 18
19 void setStart(Node node, long offset); 19 void setStart(Node node, unsigned long offset);
20 void setEnd(Node node, long offset); 20 void setEnd(Node node, unsigned long offset);
21 21
22 [NewObject, RaisesException] Range toRange(); 22 [NewObject, RaisesException] Range toRange();
foolip 2017/04/04 04:17:12 The spec never throws an exception, can you invest
chongz 2017/04/04 15:22:32 It relies on |Range::setStart()| and |Range::setEn
foolip 2017/04/04 16:10:52 I've filed https://github.com/garykac/staticrange/
23 }; 23 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/StaticRange.cpp ('k') | third_party/WebKit/Source/core/dom/StaticRangeTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698