Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/dom/StaticRange.idl

Issue 2793093002: [InputEvent] Update spec link for StaticRange.idl and use unsigned offset (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/StaticRange.idl
diff --git a/third_party/WebKit/Source/core/dom/StaticRange.idl b/third_party/WebKit/Source/core/dom/StaticRange.idl
index 0048076ba3ac1f15a63e76aeae7ed769dae456b8..5cc6feec5138b51cf948536d1fcb463a2eda9b7c 100644
--- a/third_party/WebKit/Source/core/dom/StaticRange.idl
+++ b/third_party/WebKit/Source/core/dom/StaticRange.idl
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
+// https://garykac.github.io/staticrange/#interface-staticrange
[
Constructor,
@@ -11,13 +11,13 @@
RuntimeEnabled=InputEvent,
] interface StaticRange {
attribute Node startContainer;
- attribute long startOffset;
+ attribute unsigned long startOffset;
attribute Node endContainer;
- attribute long endOffset;
+ attribute unsigned long endOffset;
readonly attribute boolean collapsed;
- void setStart(Node node, long offset);
- void setEnd(Node node, long offset);
+ void setStart(Node node, unsigned long offset);
+ void setEnd(Node node, unsigned long offset);
[NewObject, RaisesException] Range toRange();
foolip 2017/04/04 04:17:12 The spec never throws an exception, can you invest
chongz 2017/04/04 15:22:32 It relies on |Range::setStart()| and |Range::setEn
foolip 2017/04/04 16:10:52 I've filed https://github.com/garykac/staticrange/
};
« no previous file with comments | « third_party/WebKit/Source/core/dom/StaticRange.cpp ('k') | third_party/WebKit/Source/core/dom/StaticRangeTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698