Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2792983002: Fix constructor for AutocompleteMatch to initialize |subtype_identifier| (Closed)

Created:
3 years, 8 months ago by gcomanici
Modified:
3 years, 8 months ago
Reviewers:
Mark P
CC:
chromium-reviews, jdonnelly+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix constructor for AutocompleteMatch to initialize |subtype_identifier| This bug was due to CL https://codereview.chromium.org/2755503002/. An additional fix is applied to two comments. These were inconsisitent with the variable names it they were refering to. BUG=707537 Review-Url: https://codereview.chromium.org/2792983002 Cr-Commit-Position: refs/heads/master@{#461470} Committed: https://chromium.googlesource.com/chromium/src/+/0e282db620025b8a3e4386e67e0d76d1008c5742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/omnibox/browser/autocomplete_match.h View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/autocomplete_match.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/omnibox/browser/search_suggestion_parser.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
gcomanici
3 years, 8 months ago (2017-04-03 14:13:04 UTC) #2
Mark P
lgtm
3 years, 8 months ago (2017-04-03 16:58:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792983002/1
3 years, 8 months ago (2017-04-03 17:12:58 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 18:08:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e282db620025b8a3e4386e67e0d...

Powered by Google App Engine
This is Rietveld 408576698