Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: components/omnibox/browser/autocomplete_match.cc

Issue 2792983002: Fix constructor for AutocompleteMatch to initialize |subtype_identifier| (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/omnibox/browser/autocomplete_match.h" 5 #include "components/omnibox/browser/autocomplete_match.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 78
79 AutocompleteMatch::AutocompleteMatch() 79 AutocompleteMatch::AutocompleteMatch()
80 : provider(NULL), 80 : provider(NULL),
81 relevance(0), 81 relevance(0),
82 typed_count(-1), 82 typed_count(-1),
83 deletable(false), 83 deletable(false),
84 allowed_to_be_default_match(false), 84 allowed_to_be_default_match(false),
85 swap_contents_and_description(false), 85 swap_contents_and_description(false),
86 transition(ui::PAGE_TRANSITION_GENERATED), 86 transition(ui::PAGE_TRANSITION_GENERATED),
87 type(AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED), 87 type(AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED),
88 from_previous(false) { 88 subtype_identifier(0),
89 } 89 from_previous(false) {}
90 90
91 AutocompleteMatch::AutocompleteMatch(AutocompleteProvider* provider, 91 AutocompleteMatch::AutocompleteMatch(AutocompleteProvider* provider,
92 int relevance, 92 int relevance,
93 bool deletable, 93 bool deletable,
94 Type type) 94 Type type)
95 : provider(provider), 95 : provider(provider),
96 relevance(relevance), 96 relevance(relevance),
97 typed_count(-1), 97 typed_count(-1),
98 deletable(deletable), 98 deletable(deletable),
99 allowed_to_be_default_match(false), 99 allowed_to_be_default_match(false),
100 swap_contents_and_description(false), 100 swap_contents_and_description(false),
101 transition(ui::PAGE_TRANSITION_TYPED), 101 transition(ui::PAGE_TRANSITION_TYPED),
102 type(type), 102 type(type),
103 from_previous(false) { 103 subtype_identifier(0),
104 } 104 from_previous(false) {}
105 105
106 AutocompleteMatch::AutocompleteMatch(const AutocompleteMatch& match) 106 AutocompleteMatch::AutocompleteMatch(const AutocompleteMatch& match)
107 : provider(match.provider), 107 : provider(match.provider),
108 relevance(match.relevance), 108 relevance(match.relevance),
109 typed_count(match.typed_count), 109 typed_count(match.typed_count),
110 deletable(match.deletable), 110 deletable(match.deletable),
111 fill_into_edit(match.fill_into_edit), 111 fill_into_edit(match.fill_into_edit),
112 inline_autocompletion(match.inline_autocompletion), 112 inline_autocompletion(match.inline_autocompletion),
113 allowed_to_be_default_match(match.allowed_to_be_default_match), 113 allowed_to_be_default_match(match.allowed_to_be_default_match),
114 destination_url(match.destination_url), 114 destination_url(match.destination_url),
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
623 << " is unsorted in relation to last offset of " << last_offset 623 << " is unsorted in relation to last offset of " << last_offset
624 << ". Provider: " << provider_name << "."; 624 << ". Provider: " << provider_name << ".";
625 DCHECK_LT(i->offset, text.length()) 625 DCHECK_LT(i->offset, text.length())
626 << " Classification of [" << i->offset << "," << text.length() 626 << " Classification of [" << i->offset << "," << text.length()
627 << "] is out of bounds for \"" << text << "\". Provider: " 627 << "] is out of bounds for \"" << text << "\". Provider: "
628 << provider_name << "."; 628 << provider_name << ".";
629 last_offset = i->offset; 629 last_offset = i->offset;
630 } 630 }
631 } 631 }
632 #endif 632 #endif
OLDNEW
« no previous file with comments | « components/omnibox/browser/autocomplete_match.h ('k') | components/omnibox/browser/search_suggestion_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698