Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: components/omnibox/browser/autocomplete_match.h

Issue 2792983002: Fix constructor for AutocompleteMatch to initialize |subtype_identifier| (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/omnibox/browser/autocomplete_match.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_MATCH_H_ 5 #ifndef COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_MATCH_H_
6 #define COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_MATCH_H_ 6 #define COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_MATCH_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 361
362 // The transition type to use when the user opens this match. By default 362 // The transition type to use when the user opens this match. By default
363 // this is TYPED. Providers whose matches do not look like URLs should set 363 // this is TYPED. Providers whose matches do not look like URLs should set
364 // it to GENERATED. 364 // it to GENERATED.
365 ui::PageTransition transition; 365 ui::PageTransition transition;
366 366
367 // Type of this match. 367 // Type of this match.
368 Type type; 368 Type type;
369 369
370 // Used to identify the specific source / type for suggestions by the 370 // Used to identify the specific source / type for suggestions by the
371 // suggest server. See |result_type_identifier| in omnibox.proto for more 371 // suggest server. See |result_subtype_identifier| in omnibox.proto for more
372 // details. 372 // details.
373 // The identifier 0 is reserved for cases where this specific type is unset. 373 // The identifier 0 is reserved for cases where this specific type is unset.
374 int subtype_identifier; 374 int subtype_identifier;
375 375
376 // Set with a keyword provider match if this match can show a keyword hint. 376 // Set with a keyword provider match if this match can show a keyword hint.
377 // For example, if this is a SearchProvider match for "www.amazon.com", 377 // For example, if this is a SearchProvider match for "www.amazon.com",
378 // |associated_keyword| could be a KeywordProvider match for "amazon.com". 378 // |associated_keyword| could be a KeywordProvider match for "amazon.com".
379 // 379 //
380 // When this is set, the popup will show a ">" symbol at the right edge of the 380 // When this is set, the popup will show a ">" symbol at the right edge of the
381 // line for this match, and tab/shift-tab will toggle in and out of keyword 381 // line for this match, and tab/shift-tab will toggle in and out of keyword
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 const base::string16& text, 425 const base::string16& text,
426 const ACMatchClassifications& classifications) const; 426 const ACMatchClassifications& classifications) const;
427 #endif 427 #endif
428 }; 428 };
429 429
430 typedef AutocompleteMatch::ACMatchClassification ACMatchClassification; 430 typedef AutocompleteMatch::ACMatchClassification ACMatchClassification;
431 typedef std::vector<ACMatchClassification> ACMatchClassifications; 431 typedef std::vector<ACMatchClassification> ACMatchClassifications;
432 typedef std::vector<AutocompleteMatch> ACMatches; 432 typedef std::vector<AutocompleteMatch> ACMatches;
433 433
434 #endif // COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_MATCH_H_ 434 #endif // COMPONENTS_OMNIBOX_BROWSER_AUTOCOMPLETE_MATCH_H_
OLDNEW
« no previous file with comments | « no previous file | components/omnibox/browser/autocomplete_match.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698