Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Side by Side Diff: components/omnibox/browser/search_suggestion_parser.h

Issue 2792983002: Fix constructor for AutocompleteMatch to initialize |subtype_identifier| (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/omnibox/browser/autocomplete_match.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OMNIBOX_BROWSER_SEARCH_SUGGESTION_PARSER_H_ 5 #ifndef COMPONENTS_OMNIBOX_BROWSER_SEARCH_SUGGESTION_PARSER_H_
6 #define COMPONENTS_OMNIBOX_BROWSER_SEARCH_SUGGESTION_PARSER_H_ 6 #define COMPONENTS_OMNIBOX_BROWSER_SEARCH_SUGGESTION_PARSER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 // The contents to be displayed and its style info. 84 // The contents to be displayed and its style info.
85 base::string16 match_contents_; 85 base::string16 match_contents_;
86 ACMatchClassifications match_contents_class_; 86 ACMatchClassifications match_contents_class_;
87 87
88 // True if the result came from the keyword provider. 88 // True if the result came from the keyword provider.
89 bool from_keyword_provider_; 89 bool from_keyword_provider_;
90 90
91 AutocompleteMatchType::Type type_; 91 AutocompleteMatchType::Type type_;
92 92
93 // Used to identify the specific source / type for suggestions by the 93 // Used to identify the specific source / type for suggestions by the
94 // suggest server. See |result_type_identifier| in omnibox.proto for more 94 // suggest server. See |result_subtype_identifier| in omnibox.proto for more
95 // details. 95 // details.
96 // The identifier 0 is reserved for cases where this specific type is unset. 96 // The identifier 0 is reserved for cases where this specific type is unset.
97 int subtype_identifier_; 97 int subtype_identifier_;
98 98
99 // The relevance score. 99 // The relevance score.
100 int relevance_; 100 int relevance_;
101 101
102 private: 102 private:
103 // Whether this result's relevance score was fully or partly calculated 103 // Whether this result's relevance score was fully or partly calculated
104 // based on server information, and thus is assumed to be more accurate. 104 // based on server information, and thus is assumed to be more accurate.
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 const AutocompleteSchemeClassifier& scheme_classifier, 307 const AutocompleteSchemeClassifier& scheme_classifier,
308 int default_result_relevance, 308 int default_result_relevance,
309 bool is_keyword_result, 309 bool is_keyword_result,
310 Results* results); 310 Results* results);
311 311
312 private: 312 private:
313 DISALLOW_COPY_AND_ASSIGN(SearchSuggestionParser); 313 DISALLOW_COPY_AND_ASSIGN(SearchSuggestionParser);
314 }; 314 };
315 315
316 #endif // COMPONENTS_OMNIBOX_BROWSER_SEARCH_SUGGESTION_PARSER_H_ 316 #endif // COMPONENTS_OMNIBOX_BROWSER_SEARCH_SUGGESTION_PARSER_H_
OLDNEW
« no previous file with comments | « components/omnibox/browser/autocomplete_match.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698