Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2792403002: //tools/binary_size: Change merge symbols to have their size as padding (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

//tools/binary_size: Change merge symbols to have their size as padding Plus more small tweaks to formatting for Print() NOTRY=true BUG=681694 Review-Url: https://codereview.chromium.org/2792403002 Cr-Commit-Position: refs/heads/master@{#461931} Committed: https://chromium.googlesource.com/chromium/src/+/0f7f2aba1845c834c9ce19b76abeff059b6f8f2e

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -179 lines) Patch
M tools/binary_size/describe.py View 2 chunks +12 lines, -4 lines 0 comments Download
M tools/binary_size/linker_map_parser.py View 2 chunks +13 lines, -11 lines 0 comments Download
M tools/binary_size/map2size.py View 1 chunk +36 lines, -28 lines 0 comments Download
M tools/binary_size/models.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tools/binary_size/testdata/ActualDiff.golden View 2 chunks +89 lines, -54 lines 0 comments Download
M tools/binary_size/testdata/Map2Size.golden View 1 chunk +42 lines, -42 lines 0 comments Download
M tools/binary_size/testdata/SymbolGroupMethods.golden View 1 chunk +35 lines, -35 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
agrieve
On 2017/04/04 18:29:53, agrieve wrote: > Description was changed from > > ========== > Change ...
3 years, 8 months ago (2017-04-04 18:29:58 UTC) #4
estevenson
lgtm
3 years, 8 months ago (2017-04-04 20:11:30 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2795593005 Patch 60001). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-04 20:22:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792403002/20001
3 years, 8 months ago (2017-04-05 01:18:07 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 01:29:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f7f2aba1845c834c9ce19b76abe...

Powered by Google App Engine
This is Rietveld 408576698