Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2503)

Unified Diff: tools/binary_size/models.py

Issue 2792403002: //tools/binary_size: Change merge symbols to have their size as padding (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/map2size.py ('k') | tools/binary_size/testdata/ActualDiff.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/models.py
diff --git a/tools/binary_size/models.py b/tools/binary_size/models.py
index ecc3527e88c6a633cea991ee75cb68bbce21c728..11494faa8d4a4609f68a7ed45517394ae51ef1de 100644
--- a/tools/binary_size/models.py
+++ b/tools/binary_size/models.py
@@ -113,10 +113,10 @@ class Symbol(BaseSymbol):
self.padding = 0
def __repr__(self):
- return '%s@%x(size=%d,padding=%d,name=%s,path=%s,anon=%d)' % (
- self.section_name, self.address, self.size_without_padding,
- self.padding, self.name, self.source_path or self.object_path,
- int(self.is_anonymous))
+ return ('%s@%x(size_without_padding=%d,padding=%d,name=%s,path=%s,anon=%d)'
+ % (self.section_name, self.address, self.size_without_padding,
+ self.padding, self.name, self.source_path or self.object_path,
+ int(self.is_anonymous)))
class SymbolGroup(BaseSymbol):
@@ -573,7 +573,7 @@ def Diff(new, old):
for section_name, padding in padding_by_section_name.iteritems():
similar.append(Symbol(section_name, padding,
- name='** aggregate padding of delta symbols'))
+ name="** aggregate padding of diff'ed symbols"))
return SymbolDiff(added, removed, similar)
« no previous file with comments | « tools/binary_size/map2size.py ('k') | tools/binary_size/testdata/ActualDiff.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698