//tools/binary_size: Various enhancements to console.py

//tools/binary_size: Various enhancements to console.py

* Map input to "size_info" rather than "size_info1" when there is only
  one input
* For convenience, add variable "symbols = size_info.symbols"
* Don't re-sort if SymbolGroup passed to Print() is already sorted
* Add more information to Print(verbose=True)
* Add a regex helper for looking for names in camelCase/snake_case/etc
* Allow group[0xADDRESS] to return the symbol at that address
* Revert object_path transformation to how it was before last commit:
   foo/bar.a/baz.o not, foo/bar.a/(baz.o)
   Because you expect .endswith('.o').
* Filled out my pydoc.

NOTRY=true
BUG=681694
Review-Url: https://codereview.chromium.org/2795593005
Cr-Commit-Position: refs/heads/master@{#461821}
Committed: https://chromium.googlesource.com/chromium/src/+/728a4d51cdd2ccbd6e3e0e81dad77cdb0834f90f

[agrieve, 2017-04-04 15:06:43]

Description was changed from

==========
//tools/binary_size: Various enhancements to console.py

* Map input to "size_info" rather than "size_info1" when there is only
  one input
* For convenience, add variable "symbols = size_info.symbols"
* Don't re-sort if SymbolGroup passed to Print() is already sorted
* Add more information to Print(verbose=True)
* Add a regex helper for looking for names in camelCase/snake_case/etc
* Filled out my pydoc.

BUG=681694
==========

to

==========
//tools/binary_size: Various enhancements to console.py

* Map input to "size_info" rather than "size_info1" when there is only
  one input
* For convenience, add variable "symbols = size_info.symbols"
* Don't re-sort if SymbolGroup passed to Print() is already sorted
* Add more information to Print(verbose=True)
* Add a regex helper for looking for names in camelCase/snake_case/etc
* Allow group[0xADDRESS] to return the symbol at that address
* Revert object_path transformation to how it was before last commit:
   foo/bar.a/baz.o not, foo/bar.a/(baz.o)
   Because you expect .endswith('.o').
* Filled out my pydoc.

BUG=681694
==========

[agrieve, 2017-04-04 15:06:44]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-04-04 15:07:01]

On 2017/04/04 15:06:44, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

[estevenson, 2017-04-04 19:55:07]

lgtm

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/conso...
File tools/binary_size/console.py (right):

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/conso...
tools/binary_size/console.py:133: 'print_syms =
symbols.WhereMatches(r"{{_print_}}")',
Might be worth documenting the regex matching a little more here, though we
probably don't want to complicate the banner too much, your call.

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/match...
File tools/binary_size/match_util.py (right):

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/match...
tools/binary_size/match_util.py:34: camel_remainder += token[0].upper() +
token[1:]
nit: camel_remainder += token.title()?

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/model...
File tools/binary_size/models.py (right):

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/model...
tools/binary_size/models.py:329: # Symbols within third_party that contain the
string "foo".
nit: wouldn't this be: "Symbols in third_party that don't contain the string
"foo"

[agrieve, 2017-04-04 20:11:57]

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/conso...
File tools/binary_size/console.py (right):

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/conso...
tools/binary_size/console.py:133: 'print_syms =
symbols.WhereMatches(r"{{_print_}}")',
On 2017/04/04 19:55:07, estevenson wrote:
> Might be worth documenting the regex matching a little more here, though we
> probably don't want to complicate the banner too much, your call.

Done.

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/match...
File tools/binary_size/match_util.py (right):

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/match...
tools/binary_size/match_util.py:34: camel_remainder += token[0].upper() +
token[1:]
On 2017/04/04 19:55:07, estevenson wrote:
> nit: camel_remainder += token.title()?

Done.

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/model...
File tools/binary_size/models.py (right):

https://codereview.chromium.org/2795593005/diff/40001/tools/binary_size/model...
tools/binary_size/models.py:329: # Symbols within third_party that contain the
string "foo".
On 2017/04/04 19:55:07, estevenson wrote:
> nit: wouldn't this be: "Symbols in third_party that don't contain the string
> "foo"

Done.

[agrieve, 2017-04-04 20:14:29]

Description was changed from

==========
//tools/binary_size: Various enhancements to console.py

* Map input to "size_info" rather than "size_info1" when there is only
  one input
* For convenience, add variable "symbols = size_info.symbols"
* Don't re-sort if SymbolGroup passed to Print() is already sorted
* Add more information to Print(verbose=True)
* Add a regex helper for looking for names in camelCase/snake_case/etc
* Allow group[0xADDRESS] to return the symbol at that address
* Revert object_path transformation to how it was before last commit:
   foo/bar.a/baz.o not, foo/bar.a/(baz.o)
   Because you expect .endswith('.o').
* Filled out my pydoc.

BUG=681694
==========

to

==========
//tools/binary_size: Various enhancements to console.py

* Map input to "size_info" rather than "size_info1" when there is only
  one input
* For convenience, add variable "symbols = size_info.symbols"
* Don't re-sort if SymbolGroup passed to Print() is already sorted
* Add more information to Print(verbose=True)
* Add a regex helper for looking for names in camelCase/snake_case/etc
* Allow group[0xADDRESS] to return the symbol at that address
* Revert object_path transformation to how it was before last commit:
   foo/bar.a/baz.o not, foo/bar.a/(baz.o)
   Because you expect .endswith('.o').
* Filled out my pydoc.

NOTRY=true
BUG=681694
==========

[agrieve, 2017-04-04 20:15:04]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-04-04 20:15:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2795593005/#ps60001
(title: "Review fixes")

[commit-bot: I haz the power, 2017-04-04 20:15:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 20:39:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491336904538500,
"parent_rev": "e6b9e4ff7e481982e07848a0e2d20d9caf0f25c2", "commit_rev":
"728a4d51cdd2ccbd6e3e0e81dad77cdb0834f90f"}

[commit-bot: I haz the power, 2017-04-04 20:40:47]

Description was changed from

==========
//tools/binary_size: Various enhancements to console.py

* Map input to "size_info" rather than "size_info1" when there is only
  one input
* For convenience, add variable "symbols = size_info.symbols"
* Don't re-sort if SymbolGroup passed to Print() is already sorted
* Add more information to Print(verbose=True)
* Add a regex helper for looking for names in camelCase/snake_case/etc
* Allow group[0xADDRESS] to return the symbol at that address
* Revert object_path transformation to how it was before last commit:
   foo/bar.a/baz.o not, foo/bar.a/(baz.o)
   Because you expect .endswith('.o').
* Filled out my pydoc.

NOTRY=true
BUG=681694
==========

to

==========
//tools/binary_size: Various enhancements to console.py

* Map input to "size_info" rather than "size_info1" when there is only
  one input
* For convenience, add variable "symbols = size_info.symbols"
* Don't re-sort if SymbolGroup passed to Print() is already sorted
* Add more information to Print(verbose=True)
* Add a regex helper for looking for names in camelCase/snake_case/etc
* Allow group[0xADDRESS] to return the symbol at that address
* Revert object_path transformation to how it was before last commit:
   foo/bar.a/baz.o not, foo/bar.a/(baz.o)
   Because you expect .endswith('.o').
* Filled out my pydoc.

NOTRY=true
BUG=681694

Review-Url: https://codereview.chromium.org/2795593005
Cr-Commit-Position: refs/heads/master@{#461821}
Committed:
https://chromium.googlesource.com/chromium/src/+/728a4d51cdd2ccbd6e3e0e81dad7...
==========

[commit-bot: I haz the power, 2017-04-04 20:40:48]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/728a4d51cdd2ccbd6e3e0e81dad7...