Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/binary_size/describe.py

Issue 2792403002: //tools/binary_size: Change merge symbols to have their size as padding (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/binary_size/linker_map_parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/describe.py
diff --git a/tools/binary_size/describe.py b/tools/binary_size/describe.py
index 7b92326efaa8dbceacbf9a8fb9b4de6f18422a4c..3bae8f7aa8051e90dc043d6094c8f9b41fdd5a75 100644
--- a/tools/binary_size/describe.py
+++ b/tools/binary_size/describe.py
@@ -48,6 +48,14 @@ class Describer(object):
percent = float(size) / total_bytes if total_bytes else 0
yield '{}: {:,} bytes ({:.1%})'.format(name, size, percent)
+ if self.verbose:
+ yield ''
+ yield 'Other section sizes:'
+ section_names = sorted(k for k in section_sizes.iterkeys()
+ if k not in section_names)
+ for name in section_names:
+ yield '{}: {:,} bytes'.format(name, section_sizes[name])
+
def _DescribeSymbol(self, sym):
# SymbolGroups are passed here when we don't want to expand them.
if sym.IsGroup():
@@ -68,11 +76,11 @@ class Describer(object):
yield ' source_path={} \tobject_path={}'.format(
sym.source_path, sym.object_path)
if sym.full_name:
- yield ' full_name={} \tis_anonymous={}'.format(
- sym.full_name, sym.is_anonymous)
+ yield ' is_anonymous={} full_name={}'.format(
+ int(sym.is_anonymous), sym.full_name)
if sym.name:
- yield ' name={} \tis_anonymous={}'.format(
- sym.name, sym.is_anonymous)
+ yield ' is_anonymous={} name={}'.format(
+ int(sym.is_anonymous), sym.name)
else:
yield '{}@0x{:<8x} {:<7} {}'.format(
sym.section, sym.address, sym.size,
« no previous file with comments | « no previous file | tools/binary_size/linker_map_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698