Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2791883002:
Optimize ClipRects in the PrePaintTreeWalk (Closed)
|
Created:
3 years, 8 months ago by chrishtr Modified:
3 years, 8 months ago Reviewers:
Xianzhu CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionOptimize ClipRects in the PrePaintTreeWalk.
1. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper
now checks for transforms on infininte rects instead).
2. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk.
This is https://codereview.chromium.org/2784963002 without the change to
remove RefPtrs for ClipRects.
BUG=692614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2791883002
Cr-Commit-Position: refs/heads/master@{#461478}
Committed: https://chromium.googlesource.com/chromium/src/+/ca2623e17b5c45400485a2ceb08545baa9f09c4f
Patch Set 1 #Patch Set 2 : none #Patch Set 3 : none #Patch Set 4 : none #Patch Set 5 : none #Patch Set 6 : gc #Patch Set 7 : none #Patch Set 8 : none #Patch Set 9 : none #Patch Set 10 : none #
Total comments: 2
Patch Set 11 : none #
Messages
Total messages: 34 (29 generated)
Description was changed from ========== none none none Revert "Optimize the pre-paint tree walk and ClipRects." This reverts commit 65b5d60ab86950a42ade9f0aee9e5e67d8c3ff20. BUG= ========== to ========== none none none Revert "Optimize the pre-paint tree walk and ClipRects." This reverts commit 65b5d60ab86950a42ade9f0aee9e5e67d8c3ff20. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none none none Revert "Optimize the pre-paint tree walk and ClipRects." This reverts commit 65b5d60ab86950a42ade9f0aee9e5e67d8c3ff20. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Optimize ClipRects in the PrePaintTreeWalk. 1. Don't compute clip rects for PaintLayers that don't support subsequence caching (pre-SPInvalidation code did this already). 2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper now checks for transforms on infininte rects instead). 3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== Optimize ClipRects in the PrePaintTreeWalk. 1. Don't compute clip rects for PaintLayers that don't support subsequence caching (pre-SPInvalidation code did this already). 2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper now checks for transforms on infininte rects instead). 3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Optimize ClipRects in the PrePaintTreeWalk. 1. Don't compute clip rects for PaintLayers that don't support subsequence caching (pre-SPInvalidation code did this already). 2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper now checks for transforms on infininte rects instead). 3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk. BUG=692614 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
The CQ bit was unchecked by chrishtr@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Optimize ClipRects in the PrePaintTreeWalk. 1. Don't compute clip rects for PaintLayers that don't support subsequence caching (pre-SPInvalidation code did this already). 2. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper now checks for transforms on infininte rects instead). 3. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk. BUG=692614 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Optimize ClipRects in the PrePaintTreeWalk. 1. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper now checks for transforms on infininte rects instead). 2. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk. This is https://codereview.chromium.org/2784963002 without the change to remove RefPtrs for ClipRects. BUG=692614 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
chrishtr@chromium.org changed reviewers: + wangxianzhu@chromium.org
lgtm https://codereview.chromium.org/2791883002/diff/170001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h (right): https://codereview.chromium.org/2791883002/diff/170001/third_party/WebKit/Sou... third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h:40: // by ancestorPaintOffset. Sets hasClip to true if a clip was applied. Remove the sentence about 'hasClip'.
The CQ bit was checked by chrishtr@chromium.org
https://codereview.chromium.org/2791883002/diff/170001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h (right): https://codereview.chromium.org/2791883002/diff/170001/third_party/WebKit/Sou... third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h:40: // by ancestorPaintOffset. Sets hasClip to true if a clip was applied. On 2017/04/03 at 16:30:15, Xianzhu wrote: > Remove the sentence about 'hasClip'. Done.
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2791883002/#ps190001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 190001, "attempt_start_ts": 1491237401921890,
"parent_rev": "63c6a43f5ddaf465dadc3795ec78703652a56b5d", "commit_rev":
"ca2623e17b5c45400485a2ceb08545baa9f09c4f"}
Message was sent while issue was closed.
Description was changed from ========== Optimize ClipRects in the PrePaintTreeWalk. 1. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper now checks for transforms on infininte rects instead). 2. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk. This is https://codereview.chromium.org/2784963002 without the change to remove RefPtrs for ClipRects. BUG=692614 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Optimize ClipRects in the PrePaintTreeWalk. 1. Get rid of now-unnecessary logic to check clipping ancestors (GeomteryMapper now checks for transforms on infininte rects instead). 2. ALWAYS_INLINE on some helper methods of PrePaintTreeWalk. This is https://codereview.chromium.org/2784963002 without the change to remove RefPtrs for ClipRects. BUG=692614 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2791883002 Cr-Commit-Position: refs/heads/master@{#461478} Committed: https://chromium.googlesource.com/chromium/src/+/ca2623e17b5c45400485a2ceb085... ==========
Message was sent while issue was closed.
Committed patchset #11 (id:190001) as https://chromium.googlesource.com/chromium/src/+/ca2623e17b5c45400485a2ceb085... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
